retrieve() missing 1 required positional argument: 'pk'

[juliGer]

Hello @hishnash! I am trying to send the pk to the view but it would not be finding how, I tried the following and it would not be working for me I am using as_view_consumer

chatSocket.onopen = () => {
            chatSocket.send(
                JSON.stringify({
                    pk: 1,  // not work
                    query: { pk: 1 },  // not work
                    parameters: { pk: 1 }  // not work
                    action: 'retrieve',
                    request_id: new Date().getTime()
                })
            );
        };

Here I leave how the retrieve is defined

class ViewSet(viewsets.ViewSet)
    def retrieve(self, request, pk, *args, **kwargs):

Thanks greetings!

[hishnash]

this is strange parameters should be working here.

This works:

   class TestView(viewsets.ViewSet):
        def retrieve(self, request, pk, *args, **kwargs):
            results["TestView-retrieve"] = pk
            return Response(self.request.GET)

    # Test a normal connection
    communicator = WebsocketCommunicator(
        view_as_consumer(TestView.as_view({'get': 'retrieve'})), "/testws/"
    )

    connected, _ = await communicator.connect()
    assert connected

    await communicator.send_json_to(
        {"action": "retrieve", "request_id": 1, "parameters": {"pk": 42}}
    )

    response = await communicator.receive_json_from()

    assert results["TestView-retrieve"] == 42

    assert response == {
        "errors": [],
        "data": {},
        "action": "retrieve",
        "response_status": 200,
        "request_id": 1,
    }
 

[PositivPy]

I have the same issue using the example in the docs:

# asgi.py
websocket_urlpatterns=[
    path("ws/api/section/", view_as_consumer(
        views.BaseSectionContentViewSet.as_view({'get': 'retrieve'})
    )),
]

The request has no parameters:

# def retrieve vars:
{'action_map': {'get': 'retrieve', 'head': 'retrieve'}, 
'get': <bound method BaseSectionContentViewSet.retrieve of <landing.views.BaseSectionContentViewSet object at 0xffff850a44d0>>, 
'head': <bound method BaseSectionContentViewSet.retrieve of <landing.views.BaseSectionContentViewSet object at 0xffff850a44d0>>, 
'request': <rest_framework.request.Request: GET '/ws/api/section'>, 'args': (), 'kwargs': {}, '_negotiator': <rest_framework.negotiation.DefaultContentNegotiation object at 0xffff850a7090>, 'action': 'retrieve', 
'headers': {'Allow': 'GET, HEAD, OPTIONS', 'Vary': 'Accept'}, 'format_kwarg': None}

# Solution
Looking at the DjangoViewAsConsumer call_view and get_view_args, a working request should look like this:

ws.onopen = function(){
        ws.send(JSON.stringify({
            'action': "retrieve",
            'request_id': new Date().getTime(),
            'parameters': {
                'pk': 1,    # don't forget this
                'query': {'get_params': 1},
                'data': {'post_params': 1}
             },
        }))
    }

parameters are the request's parameters. query is the request.GET data and data maps to request.POST.