Moved lookup operations from detail:: (#269)

Author: Iluvmagick

include/nil/blueprint/blueprint/plonk/circuit.hpp

@@ -70,7 +70,7 @@ namespace nil {
             using lookup_gate_id_type = lookup_gate_id<BlueprintFieldType, ArithmetizationParams>;
             using lookup_gate_selector_map = std::map<lookup_gate_id_type, std::size_t>;
 
-            using lookup_table_definition = typename nil::crypto3::zk::snark::detail::lookup_table_definition<BlueprintFieldType>;
+            using lookup_table_definition = typename nil::crypto3::zk::snark::lookup_table_definition<BlueprintFieldType>;
 
             gate_selector_map selector_map = {};
             lookup_gate_selector_map lookup_selector_map = {};

include/nil/blueprint/blueprint/plonk/circuit_proxy.hpp

@@ -49,7 +49,7 @@ namespace nil {
         private:
             using constraint_type = crypto3::zk::snark::plonk_constraint<BlueprintFieldType>;
             using lookup_constraint_type = crypto3::zk::snark::plonk_lookup_constraint<BlueprintFieldType>;
-            using lookup_table_definition = typename nil::crypto3::zk::snark::detail::lookup_table_definition<BlueprintFieldType>;
+            using lookup_table_definition = typename nil::crypto3::zk::snark::lookup_table_definition<BlueprintFieldType>;
 
             std::uint32_t id;
             std::shared_ptr<circuit<ArithmetizationType>> circuit_ptr;

include/nil/blueprint/components/algebra/fields/plonk/non_native/lookup_logic_ops.hpp

@@ -52,7 +52,7 @@ namespace nil {
             class lookup_logic_and<crypto3::zk::snark::plonk_constraint_system<BlueprintFieldType, ArithmetizationParams>>
                 : public boolean_lookup_op_component<crypto3::zk::snark::plonk_constraint_system< BlueprintFieldType, ArithmetizationParams>>
             {
-                using lookup_table_definition = typename nil::crypto3::zk::snark::detail::lookup_table_definition<BlueprintFieldType>;
+                using lookup_table_definition = typename nil::crypto3::zk::snark::lookup_table_definition<BlueprintFieldType>;
 
                 class binary_and_table_type : public lookup_table_definition{
                 public:

include/nil/blueprint/components/hashes/sha2/plonk/sha256.hpp

@@ -137,7 +137,7 @@ namespace nil {
                     component_type(witnesses, constants, public_inputs, get_manifest()) {};
 
                 using lookup_table_definition = typename
-                    nil::crypto3::zk::snark::detail::lookup_table_definition<BlueprintFieldType>;
+                    nil::crypto3::zk::snark::lookup_table_definition<BlueprintFieldType>;
 
                 std::vector<std::shared_ptr<lookup_table_definition>> component_custom_lookup_tables(){
                     std::vector<std::shared_ptr<lookup_table_definition>> result = {};

include/nil/blueprint/lookup_library.hpp

@@ -31,7 +31,7 @@
 
 #include <boost/bimap.hpp>
 
-#include <nil/crypto3/zk/snark/arithmetization/plonk/detail/lookup_table_definition.hpp>
+#include <nil/crypto3/zk/snark/arithmetization/plonk/lookup_table_definition.hpp>
 #include <nil/blueprint/components/hashes/sha2/plonk/detail/split_functions.hpp>
 #include <nil/blueprint/components/hashes/sha2/plonk/detail/sha_table_generators.hpp>
 #include <nil/blueprint/manifest.hpp>
@@ -65,8 +65,8 @@ namespace nil {
 
         template <typename BlueprintFieldType>
         class lookup_library {
-            using lookup_table_definition = typename nil::crypto3::zk::snark::detail::lookup_table_definition<BlueprintFieldType>;
-            using filled_lookup_table_definition = typename nil::crypto3::zk::snark::detail::filled_lookup_table_definition<BlueprintFieldType>;
+            using lookup_table_definition = typename nil::crypto3::zk::snark::lookup_table_definition<BlueprintFieldType>;
+            using filled_lookup_table_definition = typename nil::crypto3::zk::snark::filled_lookup_table_definition<BlueprintFieldType>;
 
             class binary_xor_table_type : public lookup_table_definition{
             public:

test/test_plonk_component.hpp

@@ -284,7 +284,7 @@ namespace nil {
                 // We may start from zero if component doesn't use ordinary constants.
                 std::vector<size_t> lookup_columns_indices;
                 for( std::size_t i = 1; i < ArithmetizationParams::constant_columns; i++ )  lookup_columns_indices.push_back(i);
-                desc.usable_rows_amount = zk::snark::detail::pack_lookup_tables_horizontal(
+                desc.usable_rows_amount = zk::snark::pack_lookup_tables_horizontal(
                     bp.get_reserved_indices(),
                     bp.get_reserved_tables(),
                     bp, assignment, lookup_columns_indices,