Change is_satisfied signature to take const circuit as input (#277)

* change is_satisfied signature to take const circuit as input

* Const/mutability fixes.

---------

Co-authored-by: Iluvmagick <[email protected]>

Author: CblPOK-git

include/nil/blueprint/blueprint/plonk/circuit.hpp

@@ -181,7 +181,7 @@ namespace nil {
                 return _lookup_library.get_reserved_indices().right;
             }
 
-            virtual const std::map<std::string, std::shared_ptr<lookup_table_definition>> &get_reserved_tables() {
+            virtual const std::map<std::string, std::shared_ptr<lookup_table_definition>> &get_reserved_tables() const {
                 return _lookup_library.get_reserved_tables();
             }
 

include/nil/blueprint/blueprint/plonk/circuit_proxy.hpp

@@ -177,7 +177,7 @@ namespace nil {
                 return circuit_ptr->get_reserved_indices_right();
             }
 
-            const std::map<std::string, std::shared_ptr<lookup_table_definition>> &get_reserved_tables() override {
+            const std::map<std::string, std::shared_ptr<lookup_table_definition>> &get_reserved_tables() const override {
                 return circuit_ptr->get_reserved_tables();
             }
 

include/nil/blueprint/lookup_library.hpp

@@ -284,7 +284,7 @@ namespace nil {
                 reserved_tables_indices.left.insert(std::make_pair(name, reserved_tables.size()));
             }
 
-            void reservation_done(){
+            void reservation_done() const {
                 if(reserved_all) return;
 
                 reserved_all = true;
@@ -293,34 +293,35 @@ namespace nil {
                     std::string table_name = name.substr(0, slash_pos);
                     BOOST_ASSERT(tables.find(table_name) != tables.end());
                     std::string subtable_name = name.substr(slash_pos + 1, name.size());
-                    BOOST_ASSERT(tables[table_name]->subtables.find(subtable_name) !=
-                                 tables[table_name]->subtables.end());
+                    auto const &table = tables.at(table_name);
+                    BOOST_ASSERT(table->subtables.find(subtable_name) !=
+                                 table->subtables.end());
 
                     if( reserved_tables_map.find(table_name) == reserved_tables_map.end() ){
                         filled_lookup_table_definition *filled_definition =
-                            new filled_lookup_table_definition(*(tables[table_name]));
+                            new filled_lookup_table_definition(*(table));
                         reserved_tables_map[table_name] = std::shared_ptr<lookup_table_definition>(filled_definition);
                     }
                     reserved_tables_map[table_name]->subtables[subtable_name] =
-                        tables[table_name]->subtables[subtable_name];
+                        table->subtables[subtable_name];
                 }
             }
 
             const bimap_type &get_reserved_indices() const {
                 return reserved_tables_indices;
             }
 
-            const std::map<std::string, std::shared_ptr<lookup_table_definition>> &get_reserved_tables() {
+            const std::map<std::string, std::shared_ptr<lookup_table_definition>> &get_reserved_tables() const {
                 reservation_done();
                 return reserved_tables_map;
             }
         protected:
-            bool reserved_all;
+            mutable bool reserved_all;
 
             std::map<std::string, std::shared_ptr<lookup_table_definition>> tables;
             std::set<std::string> reserved_tables;
             bimap_type reserved_tables_indices;
-            std::map<std::string, std::shared_ptr<lookup_table_definition>> reserved_tables_map;
+            mutable std::map<std::string, std::shared_ptr<lookup_table_definition>> reserved_tables_map;
         };
     }        // namespace blueprint
 }    // namespace nil

include/nil/blueprint/utils/satisfiability_check.hpp

@@ -42,7 +42,7 @@ namespace nil {
 
         template<typename BlueprintFieldType,
                  typename ArithmetizationParams>
-        bool is_satisfied(circuit<crypto3::zk::snark::plonk_constraint_system<BlueprintFieldType,
+        bool is_satisfied(const circuit<crypto3::zk::snark::plonk_constraint_system<BlueprintFieldType,
                                                                               ArithmetizationParams>> &bp,
                           const assignment<crypto3::zk::snark::plonk_constraint_system<BlueprintFieldType,
                                                         ArithmetizationParams>> &assignments){