fix: sort the shares based on length

Author: Memo Ugurbil

src/nilql/nilql.py

@@ -948,8 +948,11 @@ def decrypt(
             except Exception as exc:
                 raise error from exc
 
-        bytes_ = bytes(shares[-1])
-        for share_ in shares[:-1]:
+        lens = [len(share) for share in shares]
+        indices = sorted(range(len(lens)), key=lambda i: -lens[i])
+        shares = [shares[i] for i in indices]
+        bytes_ = bytes(shares[0])
+        for share_ in shares[1:]:
             if len(bytes_) != len(share_):
                 share_ = _random_bytes(len(bytes_), share_)
             bytes_ = bytes(a ^ b for (a, b) in zip(bytes_, share_))

test/test_nilql.py

@@ -313,25 +313,25 @@ def test_encrypt_decrypt_for_seed(self):
         """
         Test encryption and decryption for storing.
         """
-        for cluster in [{'nodes': [{}, {}, {}]}]:
-            sk = nilql.SecretKey.generate(cluster, {'store': True})
-
-            plaintext = ("Bart Simpson is a fictional character in the American animated television series The Simpsons"
-                         " who is part of the Simpson family. Described as one of the 100 most important people of the "
-                         "20th century by Time, Bart was created and designed by Matt Groening in James L. Brooks's "
-                         "office. Bart, alongside the rest of the family, debuted in the short 'Good Night' on The "
-                         "Tracey Ullman Show on April 19, 1987. Two years later, the family received their own series, "
-                         "which premiered on Fox on December 17, 1989. Born on April Fools' Day according to Groening, "
-                         "Bart is ten years old; he is the eldest child and only son of Homer and Marge Simpson, and "
-                         "has two sisters, Lisa and Maggie. Voiced by Nancy Cartwright (pictured), Bart is known for "
-                         "his mischievousness, rebelliousness, and disrespect for authority, as well as his prank calls"
-                         " to Moe, chalkboard gags in the opening sequence, and catchphrases. Bart is considered an "
-                         "iconic fictional television character of the 1990s and has been called an American cultural "
-                         "icon.")
-            e = nilql.encrypt(sk, plaintext)
-            self.assertEqual((len(e[0]), len(e[1]), len(e[2])), (140, 140, 1408))
-            decrypted = nilql.decrypt(sk, e)
-            self.assertEqual(decrypted, plaintext)
+        cluster = {'nodes': [{}, {}, {}]}
+        sk = nilql.SecretKey.generate(cluster, {'store': True})
+
+        plaintext = ("Bart Simpson is a fictional character in the American animated television series The Simpsons "
+                     "who is part of the Simpson family. Described as one of the 100 most important people of the "
+                     "20th century by Time, Bart was created and designed by Matt Groening in James L. Brooks's "
+                     "office. Bart, alongside the rest of the family, debuted in the short 'Good Night' on The "
+                     "Tracey Ullman Show on April 19, 1987. Two years later, the family received their own series, "
+                     "which premiered on Fox on December 17, 1989. Born on April Fools' Day according to Groening, "
+                     "Bart is ten years old; he is the eldest child and only son of Homer and Marge Simpson, and "
+                     "has two sisters, Lisa and Maggie. Voiced by Nancy Cartwright (pictured), Bart is known for "
+                     "his mischievousness, rebelliousness, and disrespect for authority, as well as his prank calls "
+                     "to Moe, chalkboard gags in the opening sequence, and catchphrases. Bart is considered an "
+                     "iconic fictional television character of the 1990s and has been called an American cultural "
+                     "icon.")
+        e = nilql.encrypt(sk, plaintext)
+        self.assertEqual((len(e[0]), len(e[1]), len(e[2])), (140, 140, 1408))
+        decrypted = nilql.decrypt(sk, [e[1], e[2], e[0]])
+        self.assertEqual(decrypted, plaintext)
 
     def test_encrypt_for_match(self):
         """