ruff: Fix B006 Do not use mutable data structures for argument defaults.

Signed-off-by: Anders Kaseorg <[email protected]>

Author: andersk

zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py

@@ -1,4 +1,4 @@
-from typing import Any, Dict, List
+from typing import Any, Dict, Sequence
 from unittest.mock import patch
 
 from typing_extensions import override
@@ -78,7 +78,7 @@ def setup_game(
         self,
         id: str = "",
         bot: Any = None,
-        players: List[str] = ["foo", "baz"],
+        players: Sequence[str] = ["foo", "baz"],
         subject: str = "test game",
         stream: str = "test",
     ) -> Any:
@@ -468,8 +468,8 @@ def test_is_user_not_player(self) -> None:
         bot = self.add_user_to_cache("foo")
         self.add_user_to_cache("baz", bot)
         bot.invites = {"abcdefg": {"host": "[email protected]", "[email protected]": "a"}}
-        self.assertFalse(bot.is_user_not_player("[email protected]"))
-        self.assertFalse(bot.is_user_not_player("[email protected]"))
+        self.assertFalse(bot.is_user_not_player("[email protected]", {}))
+        self.assertFalse(bot.is_user_not_player("[email protected]", {}))
 
     def test_move_help_message(self) -> None:
         bot = self.setup_game()

zulip_bots/zulip_bots/bots/salesforce/salesforce.py

@@ -2,7 +2,7 @@
 
 import logging
 import re
-from typing import Any, Dict, List
+from typing import Any, Collection, Dict, List
 
 import simple_salesforce
 
@@ -43,12 +43,12 @@ def get_help_text() -> str:
 
 def format_result(
     result: Dict[str, Any],
-    exclude_keys: List[str] = [],
-    force_keys: List[str] = [],
+    exclude_keys: Collection[str] = [],
+    force_keys: Collection[str] = [],
     rank_output: bool = False,
     show_all_keys: bool = False,
 ) -> str:
-    exclude_keys += ["Name", "attributes", "Id"]
+    exclude_keys = {*exclude_keys, "Name", "attributes", "Id"}
     output = ""
     if result["totalSize"] == 0:
         return "No records found."

zulip_bots/zulip_bots/game_handler.py

@@ -3,7 +3,7 @@
 import random
 import re
 from copy import deepcopy
-from typing import Any, Dict, List, Tuple
+from typing import Any, Dict, Iterable, List, Sequence, Tuple
 
 from typing_extensions import override
 
@@ -344,7 +344,7 @@ def command_accept(self, message: Dict[str, Any], sender: str, content: str) ->
         )
         self.start_game_if_ready(game_id)
 
-    def create_game_lobby(self, message: Dict[str, Any], users: List[str] = []) -> None:
+    def create_game_lobby(self, message: Dict[str, Any], users: Sequence[str] = []) -> None:
         if self.is_game_in_subject(message["subject"], message["display_recipient"]):
             self.send_reply(message, "There is already a game in this stream.")
             return
@@ -499,7 +499,7 @@ def get_sorted_player_statistics(self) -> List[Tuple[str, Dict[str, int]]]:
             reverse=True,
         )
 
-    def send_invite(self, game_id: str, user_email: str, message: Dict[str, Any] = {}) -> None:
+    def send_invite(self, game_id: str, user_email: str, message: Dict[str, Any]) -> None:
         self.invites[game_id].update({user_email.lower(): "p"})
         self.send_message(user_email, self.alert_new_invitation(game_id), True)
         if message != {}:
@@ -547,7 +547,7 @@ def get_formatted_game_object(self, game_id: str) -> str:
                 )
         return object
 
-    def join_game(self, game_id: str, user_email: str, message: Dict[str, Any] = {}) -> None:
+    def join_game(self, game_id: str, user_email: str, message: Dict[str, Any]) -> None:
         if len(self.get_players(game_id)) >= self.max_players:
             if message != {}:
                 self.send_reply(message, "This game is full.")
@@ -638,7 +638,7 @@ def parse_message(self, message: Dict[str, Any]) -> None:
         self.instances[game_id].handle_message(message["content"], message["sender_email"])
 
     def change_game_subject(
-        self, game_id: str, stream_name: str, subject_name: str, message: Dict[str, Any] = {}
+        self, game_id: str, stream_name: str, subject_name: str, message: Dict[str, Any]
     ) -> None:
         if self.get_game_instance_by_subject(stream_name, subject_name) is not None:
             if message != {}:
@@ -689,7 +689,7 @@ def get_user_cache(self) -> Dict[str, Any]:
         self.user_cache = json.loads(user_cache_str)
         return self.user_cache
 
-    def verify_users(self, users: List[str], message: Dict[str, Any] = {}) -> List[str]:
+    def verify_users(self, users: Iterable[str], message: Dict[str, Any]) -> List[str]:
         verified_users = []
         failed = False
         for u in users:
@@ -741,7 +741,7 @@ def is_game_in_subject(self, subject_name: str, stream_name: str) -> bool:
             or self.get_game_instance_by_subject(subject_name, stream_name) is not None
         )
 
-    def is_user_not_player(self, user_email: str, message: Dict[str, Any] = {}) -> bool:
+    def is_user_not_player(self, user_email: str, message: Dict[str, Any]) -> bool:
         user = self.get_user_by_email(user_email)
         if user == {}:
             if message != {}: