Skip to content

Commit 5eb84df

Browse files
iainsiains
committed
c++, contracts: Update wrapper function naming.
This uses the wrapper flag to trigger a '.contract_wrapper' append to the function names for client-side wrappers. Amends the testcases accordingly since the mangled names are no longer visible. Signed-off-by: Iain Sandoe <[email protected]>
1 parent 8db3df9 commit 5eb84df

File tree

9 files changed

+52
-49
lines changed

9 files changed

+52
-49
lines changed

‎gcc/cp/contracts.cc‎

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1547,7 +1547,8 @@ build_contract_condition_function (tree fndecl, bool pre)
15471547
DECL_NAME (fn) = copy_node (DECL_NAME (fn));
15481548
DECL_INITIAL (fn) = NULL_TREE;
15491549
CONTRACT_HELPER (fn) = pre ? ldf_contract_pre : ldf_contract_post;
1550-
DECL_CONTRACT_WRAPPER (fn) = false;
1550+
/* We might have a pre/post for a wrapper. */
1551+
DECL_CONTRACT_WRAPPER (fn) = DECL_CONTRACT_WRAPPER (fndecl);
15511552

15521553
IDENTIFIER_VIRTUAL_P (DECL_NAME (fn)) = false;
15531554
DECL_VIRTUAL_P (fn) = false;
@@ -1863,15 +1864,7 @@ build_contract_wrapper_function (tree fndecl, bool is_cvh)
18631864
if (is_cvh)
18641865
fnname = get_identifier ("handle_contract_violation.noexcept_wrapper");
18651866
else
1866-
{
1867-
/* Use mangled name so we can differentiate between different virtual
1868-
functions of the same name. */
1869-
const char *name = IDENTIFIER_POINTER ((mangle_decl_string (fndecl)));
1870-
char *buf = xasprintf ("%s.contract_wrapper", name);
1871-
fnname = get_identifier (buf);
1872-
free (buf);
1873-
}
1874-
1867+
fnname = copy_node (DECL_NAME (fndecl));
18751868
location_t loc = DECL_SOURCE_LOCATION (fndecl);
18761869

18771870
/* Handle the arg types list. */
@@ -1898,19 +1891,20 @@ build_contract_wrapper_function (tree fndecl, bool is_cvh)
18981891
if (flag_exceptions && (is_cvh || type_noexcept_p (TREE_TYPE (fndecl))))
18991892
wrapper_type = build_exception_variant (wrapper_type, noexcept_true_spec);
19001893

1901-
/* This will create a member function if fndecl is a member function, so we
1902-
will need to adjust the type later. */
19031894
tree wrapdecl
19041895
= build_lang_decl_loc (loc, FUNCTION_DECL, fnname, wrapper_type);
19051896

1906-
DECL_CONTEXT (wrapdecl) = NULL_TREE;
1897+
/* Put the wrapper in the same context as the callee. */
1898+
DECL_CONTEXT (wrapdecl) = DECL_CONTEXT (fndecl);
1899+
if (!is_cvh)
1900+
/* This declaration is a contract wrapper function. */
1901+
DECL_CONTRACT_WRAPPER (wrapdecl) = true;
1902+
19071903
DECL_SOURCE_LOCATION (wrapdecl) = loc;
19081904
/* The declaration was implicitly generated by the compiler. */
19091905
DECL_ARTIFICIAL (wrapdecl) = true;
19101906
/* Declaration, no definition yet. */
19111907
DECL_INITIAL (wrapdecl) = NULL_TREE;
1912-
/* This declaration is a contract wrapper function. */
1913-
DECL_CONTRACT_WRAPPER (wrapdecl) = true;
19141908

19151909
/* Let the start function code fill in the result decl. */
19161910
DECL_RESULT (wrapdecl) = NULL_TREE;
@@ -2351,7 +2345,6 @@ declare_noexcept_cvh_wrapper (tree fncvh_decl)
23512345
if (!wrapdecl)
23522346
{
23532347
wrapdecl = build_contract_wrapper_function (fncvh_decl, /*is_cvh*/true);
2354-
wrapdecl = pushdecl_top_level (wrapdecl);
23552348
set_contract_wrapper_function (fncvh_decl, wrapdecl);
23562349
}
23572350

@@ -2842,9 +2835,13 @@ start_function_contracts (tree fndecl)
28422835
/* If this is not a client side check and definition side checks are
28432836
disabled, do nothing. */
28442837
if (!flag_contracts_nonattr_definition_check
2845-
&& !DECL_CONTRACT_WRAPPER(fndecl))
2838+
&& !DECL_CONTRACT_WRAPPER (fndecl))
28462839
return;
28472840

2841+
/* Even if we will use an outlined function for the check (which will be the
2842+
same one we might use on the callee-side) we still need to check the re-
2843+
mapped contracts for shadowing. */
2844+
28482845
/* Check that the user did not try to shadow a function parameter with the
28492846
specified postcondition result name. */
28502847
if (flag_contracts_nonattr)

‎gcc/cp/contracts.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,10 @@ enum contract_matching_context
319319
(DECL_DECLARES_FUNCTION_P (NODE) && DECL_LANG_SPECIFIC (NODE) && \
320320
CONTRACT_HELPER (NODE) == ldf_contract_post)
321321

322+
#define DECL_IS_WRAPPER_FN_P(NODE) \
323+
(DECL_DECLARES_FUNCTION_P (NODE) && DECL_LANG_SPECIFIC (NODE) && \
324+
DECL_CONTRACT_WRAPPER (NODE))
325+
322326
extern void remove_contract_attributes (tree);
323327
extern void copy_contract_attributes (tree, tree);
324328
extern void remap_contracts (tree, tree, tree, bool);

‎gcc/cp/mangle.cc‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -819,8 +819,10 @@ write_mangled_name (const tree decl, bool top_level)
819819
write_encoding (decl);
820820
}
821821

822-
/* If this is the pre/post function for a guarded function, append
823-
.pre/post, like something from create_virtual_clone. */
822+
/* Identify helper functions for contracts support. */
823+
if (DECL_IS_WRAPPER_FN_P (decl))
824+
write_string (JOIN_STR "contract_wrapper");
825+
824826
if (DECL_IS_PRE_FN_P (decl))
825827
write_string (JOIN_STR "pre");
826828
else if (DECL_IS_POST_FN_P (decl))

‎gcc/testsuite/g++.dg/contracts/cpp26-attr/contracts-pre4.C‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,17 @@ int main(int, char**)
7878
return 0;
7979
}
8080

81-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:7: a > 5.*(\n|\r\n|\r)" }
81+
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8282
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8383
// { dg-output "Base: 13(\n|\r\n|\r)" }
84-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:7: a > 5.*(\n|\r\n|\r)" }
84+
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8585
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8686
// { dg-output "Child0: 13(\n|\r\n|\r)" }
87-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:23: a > 14.*(\n|\r\n|\r)" }
87+
// { dg-output "contract violation in function Child1::f at .*.C:23: a > 14.*(\n|\r\n|\r)" }
8888
// { dg-output "contract violation in function Child1::f at .*.C:23: a > 14.*(\n|\r\n|\r)" }
8989
// { dg-output "Child1: 27(\n|\r\n|\r)" }
9090
// { dg-output "Child2: 31(\n|\r\n|\r)" }
91-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:45: a > 0.*(\n|\r\n|\r)" }
91+
// { dg-output "contract violation in function Child3::f at .*.C:45: a > 0.*(\n|\r\n|\r)" }
9292
// { dg-output "contract violation in function Child3::f at .*.C:45: a > 0.*(\n|\r\n|\r)" }
9393
// { dg-output "Child3: 40(\n|\r\n|\r)" }
9494
// { dg-output "Child3: 41(\n|\r\n|\r)" }

‎gcc/testsuite/g++.dg/contracts/cpp26/callerside-checks/callerside-checks-all.C‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,19 @@ int main(int, char**)
3434
return 0;
3535
}
3636

37-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 2.*(\n|\r\n|\r)" }
3837
// { dg-output "contract violation in function f at .*: a > 2.*(\n|\r\n|\r)" }
38+
// { dg-output "contract violation in function f at .*: a > 2.*(\n|\r\n|\r)" }
39+
// { dg-output "contract violation in function f at .*: r > 2.*(\n|\r\n|\r)" }
3940
// { dg-output "contract violation in function f at .*: r > 2.*(\n|\r\n|\r)" }
40-
// { dg-output "contract violation in function .*contract_wrapper at .*: r > 2.*(\n|\r\n|\r)" }
41-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 3.*(\n|\r\n|\r)" }
41+
// { dg-output "contract violation in function S::f at .*: a > 3.*(\n|\r\n|\r)" }
4242
// { dg-output "contract violation in function S::f at .*: a > 3.*(\n|\r\n|\r)" }
4343
// { dg-output "contract violation in function S::f at .*: r > 3.*(\n|\r\n|\r)" }
44-
// { dg-output "contract violation in function .*contract_wrapper at .*: r > 3.*(\n|\r\n|\r)" }
45-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 4.*(\n|\r\n|\r)" }
44+
// { dg-output "contract violation in function S::f at .*: r > 3.*(\n|\r\n|\r)" }
45+
// { dg-output "contract violation in function TS<int>::f at .*: a > 4.*(\n|\r\n|\r)" }
4646
// { dg-output "contract violation in function TS<int>::f at .*: a > 4.*(\n|\r\n|\r)" }
4747
// { dg-output "contract violation in function TS<int>::f at .*: r > 4.*(\n|\r\n|\r)" }
48-
// { dg-output "contract violation in function .*contract_wrapper at .*: r > 4.*(\n|\r\n|\r)" }
49-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
48+
// { dg-output "contract violation in function TS<int>::f at .*: r > 4.*(\n|\r\n|\r)" }
49+
// { dg-output "contract violation in function TS<int>::tf at .*: a > 5.*(\n|\r\n|\r)" }
5050
// { dg-output "contract violation in function TS<int>::tf<int> at .*: a > 5.*(\n|\r\n|\r)" }
5151
// { dg-output "contract violation in function TS<int>::tf<int> at .*: r > 5.*(\n|\r\n|\r)" }
52-
// { dg-output "contract violation in function .*contract_wrapper at .*: r > 5.*(\n|\r\n|\r)" }
52+
// { dg-output "contract violation in function TS<int>::tf at .*: r > 5.*(\n|\r\n|\r)" }

‎gcc/testsuite/g++.dg/contracts/cpp26/contracts-pre4.C‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,17 @@ int main(int, char**)
7878
return 0;
7979
}
8080

81-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:7: a > 5.*(\n|\r\n|\r)" }
81+
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8282
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8383
// { dg-output "Base: 13(\n|\r\n|\r)" }
84-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:7: a > 5.*(\n|\r\n|\r)" }
84+
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8585
// { dg-output "contract violation in function Base::f at .*.C:7: a > 5.*(\n|\r\n|\r)" }
8686
// { dg-output "Child0: 13(\n|\r\n|\r)" }
87-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:23: a > 14.*(\n|\r\n|\r)" }
87+
// { dg-output "contract violation in function Child1::f at .*.C:23: a > 14.*(\n|\r\n|\r)" }
8888
// { dg-output "contract violation in function Child1::f at .*.C:23: a > 14.*(\n|\r\n|\r)" }
8989
// { dg-output "Child1: 27(\n|\r\n|\r)" }
9090
// { dg-output "Child2: 31(\n|\r\n|\r)" }
91-
// { dg-output "contract violation in function .*contract_wrapper at .*.C:45: a > 0.*(\n|\r\n|\r)" }
91+
// { dg-output "contract violation in function Child3::f at .*.C:45: a > 0.*(\n|\r\n|\r)" }
9292
// { dg-output "contract violation in function Child3::f at .*.C:45: a > 0.*(\n|\r\n|\r)" }
9393
// { dg-output "Child3: 40(\n|\r\n|\r)" }
9494
// { dg-output "Child3: 41(\n|\r\n|\r)" }

‎gcc/testsuite/g++.dg/contracts/cpp26/definition-checks/virtual-func-no-def-check2.C‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ int main(int, char**)
2727

2828
return 0;
2929
}
30-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 14.*(\n|\r\n|\r)" }
31-
// { dg-output "contract violation in function .*contract_wrapper at .*: r > 2.*(\n|\r\n|\r)" }
30+
// { dg-output "contract violation in function Base::f at .*: a > 14.*(\n|\r\n|\r)" }
31+
// { dg-output "contract violation in function Base::f at .*: r > 2.*(\n|\r\n|\r)" }

‎gcc/testsuite/g++.dg/contracts/cpp26/virtual_func1.C‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,33 +68,33 @@ int main(int, char**)
6868
return 0;
6969
}
7070

71-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
71+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
7272
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
7373
// { dg-output "Base: 3(\n|\r\n|\r)" }
74-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
74+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
7575
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
7676
// { dg-output "Child0: 3(\n|\r\n|\r)" }
77-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 14.*(\n|\r\n|\r)" }
77+
// { dg-output "contract violation in function Child1::f at .*: a > 14.*(\n|\r\n|\r)" }
7878
// { dg-output "contract violation in function Child1::f at .*: a > 14.*(\n|\r\n|\r)" }
7979
// { dg-output "Child1: 17(\n|\r\n|\r)" }
8080
// { dg-output "contract violation in function GChild1::f at .*: a > 6.*(\n|\r\n|\r)" }
81-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 6.*(\n|\r\n|\r)" }
81+
// { dg-output "contract violation in function GChild1::f at .*: a > 6.*(\n|\r\n|\r)" }
8282
// { dg-output "GChild1: 103(\n|\r\n|\r)" }
8383
// { dg-output "contract violation in function GChild2::f at .*: a > 30.*(\n|\r\n|\r)" }
84-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 30.*(\n|\r\n|\r)" }
84+
// { dg-output "contract violation in function GChild2::f at .*: a > 30.*(\n|\r\n|\r)" }
8585
// { dg-output "GChild2: 207(\n|\r\n|\r)" }
86-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
86+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
8787
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
8888
// { dg-output "fooBase.Base.: 1(\n|\r\n|\r)" }
89-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
89+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
9090
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
9191
// { dg-output "fooBase.Child0.: 1(\n|\r\n|\r)" }
92-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
92+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
9393
// { dg-output "contract violation in function Child1::f at .*: a > 14.*(\n|\r\n|\r)" }
9494
// { dg-output "fooBase.Child1.: 11(\n|\r\n|\r)" }
95-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
95+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
9696
// { dg-output "contract violation in function GChild1::f at .*: a > 6.*(\n|\r\n|\r)" }
9797
// { dg-output "fooBase.GChild1.: 101(\n|\r\n|\r)" }
98-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
98+
// { dg-output "contract violation in function Base::f at .*: a > 5.*(\n|\r\n|\r)" }
9999
// { dg-output "contract violation in function GChild2::f at .*: a > 30.*(\n|\r\n|\r)" }
100100
// { dg-output "fooBase.GChild2.: 201(\n|\r\n|\r)" }

‎gcc/testsuite/g++.dg/contracts/cpp26/virtual_func3.C‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ int main()
2525
foo(c);
2626

2727
}
28-
// { dg-output "contract violation in function .*contract_wrapper at .*: a > 5.*(\n|\r\n|\r)" }
28+
// { dg-output "contract violation in function Base<int>::f at .*: a > 5.*(\n|\r\n|\r)" }
2929
// { dg-output "contract violation in function Child1<int>::f at .*: a > 3.*(\n|\r\n|\r)" }
30-
// { dg-output "contract violation in function .*contract_wrapper at .*: i > 4.*(\n|\r\n|\r)" }
30+
// { dg-output "contract violation in function Base<int>::f at .*: i > 4.*(\n|\r\n|\r)" }

0 commit comments

Comments
 (0)