Allow any AccountTransaction linked to a Security to have an ex-date

Issue: portfolio-performance#5439

Author: buchen

name.abuchen.portfolio.tests/src/name/abuchen/portfolio/datatransfer/pdf/onvista/OnvistaPDFExtractorTest.java

@@ -38,7 +38,6 @@
 import static org.hamcrest.CoreMatchers.hasItem;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.nullValue;
 import static org.hamcrest.collection.IsEmptyCollection.empty;
 import static org.junit.Assert.assertNull;
 
@@ -3105,7 +3104,7 @@ public void testDividende15()
         assertThat(transaction.getType(), is(AccountTransaction.Type.TAXES));
 
         assertThat(transaction.getDateTime(), is(LocalDateTime.parse("2017-10-20T00:00")));
-        assertThat(transaction.getExDate(), is(nullValue()));
+        assertThat(transaction.getExDate(), is(LocalDateTime.parse("2017-10-06T00:00")));
         assertThat(transaction.getShares(), is(Values.Share.factorize(0.4512)));
         assertThat(transaction.getSource(), is("Dividende15.txt"));
         assertThat(transaction.getNote(), is("Abrechnungs-Nr. 12345678 | Ertrag für 2017"));

name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/util/viewers/ExDateEditingSupport.java

@@ -31,7 +31,7 @@ public class ExDateEditingSupport extends ColumnEditingSupport
     public boolean canEdit(Object element)
     {
         var tx = Adaptor.adapt(AccountTransaction.class, element);
-        return tx != null && tx.getType() == AccountTransaction.Type.DIVIDENDS;
+        return tx != null && tx.getSecurity() != null;
     }
 
     @Override

name.abuchen.portfolio/META-INF/services/name.abuchen.portfolio.checks.Check

@@ -14,4 +14,4 @@ name.abuchen.portfolio.checks.impl.FixWrongTransfersCheck
 name.abuchen.portfolio.checks.impl.FixDepositsWithSecurityCheck
 name.abuchen.portfolio.checks.impl.NegativeExchangeRateCheck
 name.abuchen.portfolio.checks.impl.MissingTransactionDateCheck
-name.abuchen.portfolio.checks.impl.OnlyDividendsCanHaveExDateCheck
+name.abuchen.portfolio.checks.impl.OnlyAccountTransactionsWithSecurityCanHaveExDateCheck

…mpl/OnlyDividendsCanHaveExDateCheck.java …tionsWithSecurityCanHaveExDateCheck.javaname.abuchen.portfolio/src/name/abuchen/portfolio/checks/impl/OnlyDividendsCanHaveExDateCheck.java renamed to name.abuchen.portfolio/src/name/abuchen/portfolio/checks/impl/OnlyAccountTransactionsWithSecurityCanHaveExDateCheck.java name.abuchen.portfolio/src/name/abuchen/portfolio/checks/impl/OnlyDividendsCanHaveExDateCheck.java renamed to name.abuchen.portfolio/src/name/abuchen/portfolio/checks/impl/OnlyAccountTransactionsWithSecurityCanHaveExDateCheck.java

@@ -5,10 +5,9 @@
 
 import name.abuchen.portfolio.checks.Check;
 import name.abuchen.portfolio.checks.Issue;
-import name.abuchen.portfolio.model.AccountTransaction;
 import name.abuchen.portfolio.model.Client;
 
-public class OnlyDividendsCanHaveExDateCheck implements Check
+public class OnlyAccountTransactionsWithSecurityCanHaveExDateCheck implements Check
 {
     @Override
     public List<Issue> execute(Client client)
@@ -19,7 +18,7 @@ public List<Issue> execute(Client client)
         {
             for (var tx : account.getTransactions())
             {
-                if (tx.getExDate() != null && tx.getType() != AccountTransaction.Type.DIVIDENDS)
+                if (tx.getExDate() != null && tx.getSecurity() == null)
                 {
                     tx.setExDate(null);
                 }

name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/OnvistaPDFExtractor.java

@@ -916,13 +916,6 @@ private void addDividendeTransaction()
                             if (ctx.getString(FAILURE) != null)
                                 item.setFailureMessage(ctx.getString(FAILURE));
 
-                            // ex-date is only supported for dividend
-                            // transactions. if there is a
-                            // 'Ertragsthesaurierung', then we have a tax
-                            // transaction without ex-date.
-                            if (t.getType() != AccountTransaction.Type.DIVIDENDS && t.getExDate() != null)
-                                t.setExDate(null);
-
                             return item;
                         });