plugin: add channel_closed notification

Changelog-None

Signed-off-by: Nishant Bansal <[email protected]>

Author: NishantBansal2003

lightningd/closing_control.c

@@ -31,6 +31,7 @@
 #include <lightningd/jsonrpc.h>
 #include <lightningd/lightningd.h>
 #include <lightningd/log.h>
+#include <lightningd/notification.h>
 #include <lightningd/opening_common.h>
 #include <lightningd/options.h>
 #include <lightningd/peer_control.h>
@@ -330,6 +331,13 @@ static void peer_closing_complete(struct channel *channel, const u8 *msg)
 			  REASON_UNKNOWN,
 			  "Closing complete");
 
+	struct bitcoin_txid closing_txid;
+	bitcoin_txid(channel->last_tx, &closing_txid);
+
+	/* Tell plugins about the success */
+	notify_channel_closed(channel->peer->ld, &channel->peer->id,
+			      &closing_txid);
+
 	/* Channel gets dropped to chain cooperatively. */
 	drop_to_chain(channel->peer->ld, channel, true, NULL);
 }
@@ -907,6 +915,9 @@ static struct command_result *json_close(struct command *cmd,
 	/* In case we changed anything, save it. */
 	wallet_channel_save(cmd->ld->wallet, channel);
 
+
+
+
 	/* Wait until close drops down to chain. */
 	return command_still_pending(cmd);
 

lightningd/notification.c

@@ -292,6 +292,25 @@ void notify_channel_opened(struct lightningd *ld,
 	notify_send(ld, n);
 }
 
+static void channel_closed_notification_serialize(
+    struct json_stream *stream, struct lightningd *ld,
+    const struct node_id *node_id, const struct bitcoin_txid *closing_txid)
+{
+	json_add_node_id(stream, "id", node_id);
+	json_add_txid(stream, "closing_txid", closing_txid);
+}
+
+REGISTER_NOTIFICATION(channel_closed)
+
+void notify_channel_closed(struct lightningd *ld, const struct node_id *node_id,
+			   const struct bitcoin_txid *closing_txid)
+{
+	struct jsonrpc_notification *n = notify_start("channel_closed");
+	channel_closed_notification_serialize(n->stream, ld, node_id,
+					      closing_txid);
+	notify_send(ld, n);
+}
+
 static void channel_state_changed_notification_serialize(struct json_stream *stream,
 							 const struct node_id *peer_id,
 							 const struct channel_id *cid,

lightningd/notification.h

@@ -50,6 +50,9 @@ void notify_channel_opened(struct lightningd *ld,
 			   const struct bitcoin_txid *funding_txid,
 			   bool channel_ready);
 
+void notify_channel_closed(struct lightningd *ld, const struct node_id *node_id,
+			   const struct bitcoin_txid *closing_txid);
+
 void notify_channel_state_changed(struct lightningd *ld,
 				  const struct node_id *peer_id,
 				  const struct channel_id *cid,

tests/plugins/misc_notifications.py

@@ -22,6 +22,15 @@ def channel_opened(plugin, channel_opened, **kwargs):
                        channel_opened["funding_txid"]))
 
 
+@plugin.subscribe("channel_closed")
+def channel_closed(plugin, channel_closed, **kwargs):
+    plugin.log(
+        "A channel was closed to us by {}, with a closing transaction ID: {}".format(
+            channel_closed["id"], channel_closed["closing_txid"]
+        )
+    )
+
+
 @plugin.subscribe("channel_state_changed")
 def channel_state_changed(plugin, channel_state_changed, **kwargs):
     plugin.log("channel_state_changed {}".format(channel_state_changed))

tests/test_plugin.py

@@ -1335,6 +1335,37 @@ def test_channel_opened_notification(node_factory):
                            .format(l1.info["id"], amount))
 
 
+def test_channel_closed_notification(node_factory):
+    """
+    Test the 'channel_closed' notification sent at channel closing success.
+    """
+    opts = [
+        {},
+        {"plugin": os.path.join(os.getcwd(), "tests/plugins/misc_notifications.py")},
+    ]
+    amount = 10**6
+    l1, l2 = node_factory.line_graph(2, fundchannel=True, fundamount=amount, opts=opts)
+
+    cid = l2.rpc.listpeerchannels()["channels"][0]["channel_id"]
+    closing_txid = only_one(l1.rpc.close(cid)['txids'])
+
+    # bitcoind.generate_block(6, wait_for_mempool=1)
+    # sync_blockheight(bitcoind, [l1, l2])
+
+    l1.daemon.wait_for_log(
+        r"A channel was closed to us by {}, with closing transaction id: {}".format(
+            l2.rpc.getinfo()["id"],
+            closing_txid,
+        )
+    )
+    l2.daemon.wait_for_log(
+        r"A channel was closed to us by {}, with closing transaction id: {}".format(
+            l1.rpc.getinfo()["id"],
+            closing_txid,
+        )
+    )
+
+
 def test_forward_event_notification(node_factory, bitcoind, executor):
     """ test 'forward_event' notifications
     """