version numbers missing on macOS

[core-code]

i've downloaded Version '1.0.5' but when selecting it in the Finder and using 'Get Info' it doesn't show any Version-number as it is supposed to do, but shows 'Version Nitrokey Device Manager', which is obvious nonsense.

i guess the CFBundleVersion and CFShortVersionString entries in your Info.plist file are missing or not set properly.

[alex-nitrokey]

i've downloaded Version '1.0.5'

You downloaded version 1.0.5 of what? It sounds like you are referring to a kind of software we are not able to change, but maybe I just don't understand you correctly. Please elaborate.

[szszszsz]

Hi!
@alex-nitrokey I think current Nitrokey App could be marked with invalid version string on macOS.
@core-code We never have released NK App with version 1.0.5 - could you confirm, which one have you downloaded (just in case it was already solved in latest, v1.3.2, version)?

[core-code]

sorry i meant to say version 1.3.2 not version 1.0.5

i am referring to this file:
https://github.com/Nitrokey/nitrokey-app/releases/download/v1.3.2/Nitrokey.App.dmg

[szszszsz]

OK! I plan to look into this in the next release, v1.4. Thank you for the report!

[core-code]

awesome, thanks! ;)

[core-code]

i can confirm that this issue is NOT fixed in 1.4

bug#1: the version number is contained in the filename of the App "Nitrokey App v1.4.app". this should not be done on macOS.
bug#2: the version number is NOT contained in the app itself, so that it can be displayed in the Finder, in QuickLook and everywhere else. specifically your 'CFBundleShortVersionString' and 'CFBundleVersion' keys are empty, although they should contain '1.4'

[core-code]

bug #3: when selecting the App in the Finder it claims to have version 'Nitrokey Device Manager'. this is because you've set the 'CFBundleGetInfoString' key in the Info.plist. this key has been deprecated for more than 10 years and should never be used

[szszszsz]

Hi! Thank you for checking (and for the PR)!
Indeed, fix for #388 issue has not made to v1.4 release, it is still queued to v1.5 though.

Did not know about CFBundleGetInfoString - I see you have already removed it in #422. Will look into it.

• remove version number from filename
• merge Update Info.plist #422 PR