Remove local_print, local_critical

User interactions should be handled by the application, not by the SDK.
local_print is just removed.  Instead of calling local_critical, we
return a bool so that the application can trigger the appropriate calls.

Author: robin-nitrokey

src/nitrokey/helpers.py

@@ -1,19 +1,4 @@
-import sys
 import time
-from typing import Any
-
-
-def local_print(*messages: Any, **kwargs: Any) -> None:
-    for item in messages:
-        print(item, **kwargs)
-
-
-def local_critical(
-    *messages: Any, support_hint: bool = True, ret_code: int = 1, **kwargs: Any
-) -> None:
-    messages = ("Critical error:",) + tuple(messages)
-    local_print(*messages, **kwargs)
-    sys.exit(ret_code)
 
 
 class Try:

src/nitrokey/trussed/admin_app.py

@@ -1,14 +1,11 @@
 import enum
-import sys
 from dataclasses import dataclass
 from enum import Enum, IntFlag
 from typing import Optional
 
 from fido2 import cbor
 from fido2.ctap import CtapError
 
-from nitrokey.helpers import local_critical, local_print
-
 from .device import App, NitrokeyTrussedDevice
 from .exceptions import TimeoutException
 from .utils import Uuid, Version
@@ -121,7 +118,7 @@ def check(cls, i: int, msg: str) -> None:
                 error = "The application does not support factory reset through nitropy"
             elif status == FactoryResetStatus.APP_FAILED_PARSE:
                 error = "The application name must be utf-8"
-            local_critical(f"{msg}: {error}", support_hint=False)
+            raise Exception(f"{msg}: {error}")
 
 
 @enum.unique
@@ -269,37 +266,27 @@ def set_config(self, key: str, value: str) -> None:
         assert reply
         ConfigStatus.check(reply[0], "Failed to set config value")
 
-    def factory_reset(self) -> None:
+    def factory_reset(self) -> bool:
         try:
-            local_print(
-                "Please touch the device to confirm the operation", file=sys.stderr
-            )
             reply = self._call(AdminCommand.FACTORY_RESET, response_len=1)
-            if reply is None:
-                local_critical(
-                    "Factory reset is not supported by the firmware version on the device",
-                    support_hint=False,
-                )
-                return
         except OSError as e:
             if e.errno == 5:
                 self.device.logger.debug("ignoring OSError after reboot", exc_info=e)
-                return
+                return True
             else:
                 raise e
-        FactoryResetStatus.check(reply[0], "Failed to factory reset the device")
+        if reply:
+            FactoryResetStatus.check(reply[0], "Failed to factory reset the device")
+        return reply is not None
 
-    def factory_reset_app(self, application: str) -> None:
-        local_print("Please touch the device to confirm the operation", file=sys.stderr)
+    def factory_reset_app(self, application: str) -> bool:
         reply = self._call(
             AdminCommand.FACTORY_RESET_APP,
             data=application.encode("ascii"),
             response_len=1,
         )
-        if reply is None:
-            local_critical(
-                "Application Factory reset is not supported by the firmware version on the device",
-                support_hint=False,
+        if reply:
+            FactoryResetStatus.check(
+                reply[0], "Failed to factory reset the application"
             )
-            return
-        FactoryResetStatus.check(reply[0], "Failed to factory reset the device")
+        return reply is not None