[IMP] Added functionality, removes all followers but sent to partner email addresses that are not internal users

Author: hitesh-erpharbor

mail_external_confirmation/README.rst

@@ -3,3 +3,9 @@ Mail External Confirmation
 ==========================
 This module will show confirmation dialog while sending message
 from chatter when any one follower of the record is not internal user.
+
+Displays a confirmation dialog when mentioning (@) an external user
+in chatter messages or internal notes.
+
+Triggers a confirmation popup when all followers are removed,but the message
+is still being sent to partner email addresses that are not internal users.

mail_external_confirmation/__manifest__.py

@@ -4,6 +4,12 @@
     "summary": """
     This module will show confirmation dialog while sending message
     from chatter when any one follower of the record is not internal user.
+    - Pupup the message when anyone mension in chatter or notes
+    Displays a confirmation dialog when mentioning (@) an external user
+    in chatter messages or internal notes.
+    - Triggers a confirmation popup when all followers are removed,
+    but the message is still being sent to partner email addresses
+    that are not internal users.
     """,
     "author": "Nitrokey GmbH",
     "license": "LGPL-3",

mail_external_confirmation/controllers/main.py

@@ -8,52 +8,47 @@
 
 class MessageExternalUserController(http.Controller):
     @http.route("/message/external_users/check", type="json", auth="user")
-    def check_external_users(self, rec_id, model, mentioned_partner_ids=None):
+    def check_external_users(
+        self, rec_id, model, msg_type=False, mentioned_partner_ids=None
+    ):
         """To check for external users exist in record followers"""
         confirmation_message = (
             "Your message will be sent to external partners (e.g. customers)."
         )
-        # Check thread followers
-        if not mentioned_partner_ids:
-            record = request.env[model].browse(rec_id)
-            followers = record.message_follower_ids
-            for follower in followers:
-                partner = follower.partner_id
+        popup_confirmation_msg = {
+            "needs_confirmation": True,
+            "confirmation_message": confirmation_message,
+        }
+        # Check mentioned partners (Note)
+        if mentioned_partner_ids:
+            partners = request.env["res.partner"].browse(mentioned_partner_ids).exists()
 
+            for partner in partners:
                 # If partner has no users at all, they're external
                 if not partner.user_ids:
-                    return {
-                        "needs_confirmation": True,
-                        "confirmation_message": confirmation_message,
-                    }
+                    return popup_confirmation_msg
 
                 # Check if any user is not internal
                 for user in partner.user_ids:
                     if not user.has_group("base.group_user"):
-                        return {
-                            "needs_confirmation": True,
-                            "confirmation_message": confirmation_message,
-                        }
+                        return popup_confirmation_msg
 
-        # Check mentioned partners
-        if mentioned_partner_ids:
-            partners = request.env["res.partner"].browse(mentioned_partner_ids).exists()
+        # Check thread followers (Messages)
+        if msg_type != "note":
+            record = request.env[model].browse(rec_id)
+            followers = record.message_follower_ids
+            for follower in followers:
+                partner = follower.partner_id
 
-            for partner in partners:
                 # If partner has no users at all, they're external
                 if not partner.user_ids:
-                    return {
-                        "needs_confirmation": True,
-                        "confirmation_message": confirmation_message,
-                    }
+                    return popup_confirmation_msg
 
                 # Check if any user is not internal
                 for user in partner.user_ids:
                     if not user.has_group("base.group_user"):
-                        return {
-                            "needs_confirmation": True,
-                            "confirmation_message": confirmation_message,
-                        }
+                        return popup_confirmation_msg
+
         return {
             "needs_confirmation": False,
             "confirmation_message": "",

mail_external_confirmation/static/src/core/common/composer.js

@@ -29,19 +29,38 @@ patch(Composer.prototype, {
             const checkData = {
                 rec_id: res_id,
                 model: model,
+                msg_type: this.props.type,
+                mentioned_partner_ids: [],
             };
 
-            // Add mentioned partner IDs for notes
-            if (this.props.type === "note") {
-                var mentionedPartners = this.props.composer?.mentionedPartners || null;
-                const partnerIds = this._extractPartnerIds(mentionedPartners);
+            // Add mentioned partner IDs in notes/messages
+            var mentionedPartners = this.props.composer?.mentionedPartners || null;
+            const partnerIds = this._extractPartnerIds(mentionedPartners);
 
-                if (partnerIds.length > 0) {
-                    checkData.mentioned_partner_ids = partnerIds;
-                } else {
-                    super.sendMessage();
-                    return;
-                }
+            if (partnerIds.length > 0) {
+                checkData.mentioned_partner_ids.push(...partnerIds);
+            } else {
+                // Don't have any menssion partners
+            }
+            if (this.props.type === "note" && partnerIds.length === 0) {
+                super.sendMessage();
+                return;
+            }
+
+            // Remove all followers and check checkbox of the partner email
+            const checkedPartnerIds = this.props.composer.thread.suggestedRecipients
+                .filter(
+                    (recipient) =>
+                        recipient.checked &&
+                        recipient.partner_id &&
+                        this.props.type === "message"
+                )
+                .map((recipient) => recipient.partner_id);
+            // This.props.composer.thread.followersCount //followers exist or not
+            if (checkedPartnerIds.length > 0) {
+                checkData.mentioned_partner_ids.push(...checkedPartnerIds);
+            } else {
+                // Don't have any suggestedRecipients checked
             }
 
             // Make a single RPC call to check everything