Merge pull request #1559 from NixOS/bump-nix

bump to nix v2.33

Author: Ericson2314

flake.lock

@@ -4,13 +4,13 @@
   inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-25.11-small";
 
   inputs.nix = {
-    url = "github:NixOS/nix/2.32-maintenance";
+    url = "github:NixOS/nix/2.33-maintenance";
     # We want to control the deps precisely
     flake = false;
   };
 
   inputs.nix-eval-jobs = {
-    url = "github:nix-community/nix-eval-jobs/v2.32.1";
+    url = "github:nix-community/nix-eval-jobs/v2.33.0";
     # We want to control the deps precisely
     flake = false;
   };

flake.nix

@@ -273,7 +273,7 @@ static BuildResult performBuild(
                 auto drvOutput = DrvOutput { outputHash, outputName };
                 successP->builtOutputs.insert_or_assign(
                     std::move(outputName),
-                    Realisation { drvOutput, *outputPath });
+                    Realisation { {.outPath = *outputPath}, drvOutput });
             }
         }
     }

src/hydra-queue-runner/build-remote.cc

@@ -537,12 +537,12 @@ void State::notifyBuildFinished(pqxx::work & txn, BuildID buildId,
 
 std::shared_ptr<PathLocks> State::acquireGlobalLock()
 {
-    Path lockPath = hydraData + "/queue-runner/lock";
+    auto lockPath = std::filesystem::path(hydraData) / "queue-runner/lock";
 
-    createDirs(dirOf(lockPath));
+    createDirs(lockPath.parent_path());
 
     auto lock = std::make_shared<PathLocks>();
-    if (!lock->lockPaths(PathSet({lockPath}), "", false)) return 0;
+    if (!lock->lockPaths({lockPath}, "", false)) return 0;
 
     return lock;
 }

src/hydra-queue-runner/hydra-queue-runner.cc

@@ -1,5 +1,6 @@
 #include "state.hh"
 #include "hydra-build-result.hh"
+#include <nix/store/derived-path.hh>
 #include <nix/store/globals.hh>
 #include <nix/store/parsed-derivations.hh>
 #include <nix/util/thread-pool.hh>
@@ -487,24 +488,24 @@ Step::ptr State::createStep(ref<Store> destStore,
        it's not runnable yet, and other threads won't make it
        runnable while step->created == false. */
     step->drv = std::make_unique<Derivation>(localStore->readDerivation(drvPath));
-    {
-        try {
-            step->drvOptions = std::make_unique<DerivationOptions>(
-                DerivationOptions::fromStructuredAttrs(
-                    step->drv->env,
-                    step->drv->structuredAttrs ? &*step->drv->structuredAttrs : nullptr));
-        } catch (Error & e) {
-            e.addTrace({}, "while parsing derivation '%s'", localStore->printStorePath(drvPath));
-            throw;
-        }
+    DerivationOptions<nix::SingleDerivedPath> drvOptions;
+    try {
+        drvOptions = derivationOptionsFromStructuredAttrs(
+            *localStore,
+            step->drv->inputDrvs,
+            step->drv->env,
+            get(step->drv->structuredAttrs));
+    } catch (Error & e) {
+        e.addTrace({}, "while parsing derivation '%s'", localStore->printStorePath(drvPath));
+        throw;
     }
 
-    step->preferLocalBuild = step->drvOptions->willBuildLocally(*localStore, *step->drv);
+    step->preferLocalBuild = drvOptions.willBuildLocally(*localStore, *step->drv);
     step->isDeterministic = getOr(step->drv->env, "isDetermistic", "0") == "1";
 
     step->systemType = step->drv->platform;
     {
-        StringSet features = step->requiredSystemFeatures = step->drvOptions->getRequiredSystemFeatures(*step->drv);
+        StringSet features = step->requiredSystemFeatures = drvOptions.getRequiredSystemFeatures(*step->drv);
         if (step->preferLocalBuild)
             features.insert("local");
         if (!features.empty()) {

src/hydra-queue-runner/queue-monitor.cc

@@ -172,7 +172,6 @@ struct Step
 
     nix::StorePath drvPath;
     std::unique_ptr<nix::Derivation> drv;
-    std::unique_ptr<nix::DerivationOptions> drvOptions;
     nix::StringSet requiredSystemFeatures;
     bool preferLocalBuild;
     bool isDeterministic;