-
-
Notifications
You must be signed in to change notification settings - Fork 127
terraform-iam: configure OIDC for NixOS/nix releases #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2783814 to
bcdf931
Compare
|
|
||
| locals { | ||
| administrator_role_pattern = format( | ||
| "arn:aws:iam::%s:role/aws-reserved/sso.amazonaws.com/%s/AWSReservedSSO_AWSAdministratorAccess_*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side-comment: we probably wanna have a separate IAM Identity Center Role that is not AWSAdministratorAccess for this. Maybe NixReleases or something? Then we can give the nix people access to the AWS account for manual releases without giving them admin access to the AWS account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 I was just looking into that. Then I went down the rabbit hole of configuring the management account with terraform as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I will do the other side in a follow-up PR.
f184e71 to
7bf8533
Compare
7bf8533 to
79e18ba
Compare
|
Okay so this should work in theory :-D The changes were applied so I'm going to merge this. Most likely we will need follow-up PRs. |
|
Ok it works on the other side |
|
@zimbatm I've enabled branch protection rules for the |
Make it possible to publish releases from the NixOS/nix repo.
This requires creating a "releases" environment on the Nix repo. And then wiring up GitHub Actions to publish the releases on trigger.