Skip to content

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 29, 2025

Make it possible to publish releases from the NixOS/nix repo.

This requires creating a "releases" environment on the Nix repo. And then wiring up GitHub Actions to publish the releases on trigger.

@zimbatm zimbatm requested a review from a team as a code owner October 29, 2025 10:07
@zimbatm zimbatm requested a review from arianvp October 29, 2025 10:09

locals {
administrator_role_pattern = format(
"arn:aws:iam::%s:role/aws-reserved/sso.amazonaws.com/%s/AWSReservedSSO_AWSAdministratorAccess_*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side-comment: we probably wanna have a separate IAM Identity Center Role that is not AWSAdministratorAccess for this. Maybe NixReleases or something? Then we can give the nix people access to the AWS account for manual releases without giving them admin access to the AWS account

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I was just looking into that. Then I went down the rabbit hole of configuring the management account with terraform as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I will do the other side in a follow-up PR.

@zimbatm zimbatm force-pushed the nix-releases-oidc branch 2 times, most recently from f184e71 to 7bf8533 Compare November 1, 2025 08:00
@zimbatm
Copy link
Member Author

zimbatm commented Nov 1, 2025

Okay so this should work in theory :-D

The changes were applied so I'm going to merge this. Most likely we will need follow-up PRs.

@zimbatm zimbatm enabled auto-merge November 1, 2025 08:06
@zimbatm
Copy link
Member Author

zimbatm commented Nov 2, 2025

Ok it works on the other side

@xokdvium
Copy link

xokdvium commented Nov 3, 2025

@zimbatm I've enabled branch protection rules for the release environment as suggested by NixOS/nix#14448 (comment), since the changes have been applied on the infra side already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants