Skip to content

Commit 3d877ec

Browse files
committed
derivation-goal: unlock output lock to avoid deadlock
guix discovered in their code base. Maybe we should do the same.
1 parent 5230d3e commit 3d877ec

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/libstore/build/derivation-goal.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -701,6 +701,7 @@ Goal::Co DerivationGoal::tryToBuild()
701701
if (buildMode != bmCheck && allValid) {
702702
debug("skipping build of derivation '%s', someone beat us to it", worker.store.printStorePath(drvPath));
703703
outputLocks.setDeletion(true);
704+
outputLocks.unlock();
704705
co_return done(BuildResult::AlreadyValid, std::move(validOutputs));
705706
}
706707

0 commit comments

Comments
 (0)