Skip to content

Commit 50e8d17

Browse files
committed
parser.y: use emplace_back() for vector<AttrName>
1 parent ef8dd58 commit 50e8d17

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/libexpr/parser.y

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -440,11 +440,11 @@ binds1
440440
;
441441

442442
attrs
443-
: attrs attr { $$ = std::move($1); $$.emplace_back(AttrName(state->symbols.create($2)), state->at(@2)); }
443+
: attrs attr { $$ = std::move($1); $$.emplace_back(state->symbols.create($2), state->at(@2)); }
444444
| attrs string_attr
445445
{ $$ = std::move($1);
446446
std::visit(overloaded {
447-
[&](std::string_view str) { $$.emplace_back(AttrName(state->symbols.create(str)), state->at(@2)); },
447+
[&](std::string_view str) { $$.emplace_back(state->symbols.create(str), state->at(@2)); },
448448
[&](Expr * expr) {
449449
throw ParseError({
450450
.msg = HintFmt("dynamic attributes not allowed in inherit"),
@@ -457,19 +457,19 @@ attrs
457457
;
458458

459459
attrpath
460-
: attrpath '.' attr { $$ = std::move($1); $$.push_back(AttrName(state->symbols.create($3))); }
460+
: attrpath '.' attr { $$ = std::move($1); $$.emplace_back(state->symbols.create($3)); }
461461
| attrpath '.' string_attr
462462
{ $$ = std::move($1);
463463
std::visit(overloaded {
464-
[&](std::string_view str) { $$.push_back(AttrName(state->symbols.create(str))); },
465-
[&](Expr * expr) { $$.push_back(AttrName(expr)); }
464+
[&](std::string_view str) { $$.emplace_back(state->symbols.create(str)); },
465+
[&](Expr * expr) { $$.emplace_back(expr); }
466466
}, std::move($3));
467467
}
468-
| attr { $$.push_back(AttrName(state->symbols.create($1))); }
468+
| attr { $$.emplace_back(state->symbols.create($1)); }
469469
| string_attr
470470
{ std::visit(overloaded {
471-
[&](std::string_view str) { $$.push_back(AttrName(state->symbols.create(str))); },
472-
[&](Expr * expr) { $$.push_back(AttrName(expr)); }
471+
[&](std::string_view str) { $$.emplace_back(state->symbols.create(str)); },
472+
[&](Expr * expr) { $$.emplace_back(expr); }
473473
}, std::move($1));
474474
}
475475
;

0 commit comments

Comments
 (0)