Merge pull request #14406 from NixOS/better-error-message

xokdvium · web-flow · commit e08853a67c17 · 2025-10-29T03:23:49.000Z
libstore/http-binary-cache-store: Improve error messages in HttpBinar…
diff --git a/src/libstore/http-binary-cache-store.cc b/src/libstore/http-binary-cache-store.cc
@@ -157,7 +157,9 @@ void HttpBinaryCacheStore::upsertFile(
     try {
         getFileTransfer()->upload(req);
     } catch (FileTransferError & e) {
-        throw UploadToHTTP("while uploading to HTTP binary cache at '%s': %s", config->cacheUri.to_string(), e.msg());
+        UploadToHTTP err(e.message());
+        err.addTrace({}, "while uploading to HTTP binary cache at '%s'", config->cacheUri.to_string());
+        throw err;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,9 @@ void HttpBinaryCacheStore::upsertFile(`
`157`	`157`	`try {`
`158`	`158`	`getFileTransfer()->upload(req);`
`159`	`159`	`} catch (FileTransferError & e) {`
`160`		`- throw UploadToHTTP("while uploading to HTTP binary cache at '%s': %s", config->cacheUri.to_string(), e.msg());`
	`160`	`+ UploadToHTTP err(e.message());`
	`161`	`+ err.addTrace({}, "while uploading to HTTP binary cache at '%s'", config->cacheUri.to_string());`
	`162`	`+ throw err;`
`161`	`163`	`}`
`162`	`164`	`}`
`163`	`165`