BuildResult: Add a "Cancelled" status #14559
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This denotes the result of a build that didn't succeed or fail, but was cancelled because some other goal failed and --keep-going was not enabled.
Ericson2314
reviewed
Nov 13, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
This is good, but it poses a back-compat problem for older protocols.
I think what we should do is get rid the numbers in the definition of the enum, and instead have serializers for std::variant<BuildResult::Failure, BuildResult::Success>. Then if the protocol is too old, we can map the status to something else.
(We might also switch the protocol to strings while we are at it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This denotes the result of a build that didn't succeed or fail, but was cancelled because some other goal failed and
--keep-goingwas not enabled.Cherry-picked from DeterminateSystems#217, where I'm trying to make
nix flake checkoutput more informative by showing which flake outputs failed, succeeded or were cancelled because of another failure, for example:Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.