libexpr: use allocBytes() to allocate StringData #14584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Radvendii
force-pushed
the
allocbytes-stringdata
branch
from
403b9af to
26fa5af
Compare
Ericson2314
reviewed
Nov 17, 2025
Member
There was a problem hiding this comment.
Looks good, just should update the C API first and let Robert know.
As far as I can tell, this is an unavoidable breaking change of the C API.
CC @roberth
Contributor
Author
|
To expand on what @Ericson2314 said, we discussed it in the meeting and we can anticipate that a similar change will be necessary for all the c api functions that create Values (eventually, when values themselves are stored in managed memory), so we should make those changes all now, and split it off into a separate PR. I'll try to get to that later this week. |
Radvendii
added a commit
to Radvendii/nix
that referenced
this pull request
Nov 19, 2025
We will need this argument in the future as we put things in managed memory. see NixOS#14584 for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EvalMemory::allocBytes() allows us to easily change how memory is allocated throughout the program. I have been using it to put all allocations in a bump allocator so I can more easily track memory leaks.
One problem is that this has to change the c bindings. I don't know how much of an issue this is as I haven't worked on the c bindings much until now.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.