checkpoint

Signed-off-by: lucasew <lucas59356@gmail.com>

Author: lucasew

src/references.rs

@@ -1,4 +1,5 @@
 use std::ffi::OsStr;
+use std::hash::Hash;
 use std::path::Path;
 
 use anyhow::Context;
@@ -7,7 +8,7 @@ use rnix::SyntaxNode;
 use rowan::ast::AstNode;
 
 use crate::nix_file::{NixFile, ResolvedPath};
-use crate::problem::{npv_121, npv_122, npv_123, npv_124, npv_125, npv_126};
+use crate::problem::{npv_121, npv_122, npv_123, npv_124, npv_125, npv_126, npv_169};
 use crate::structure::read_dir_sorted;
 use crate::validation::{self, ResultIteratorExt, Validation::Success};
 use crate::NixFileStore;
@@ -113,7 +114,7 @@ fn check_path(
 }
 
 fn check_nix_path(
-    node: SyntaxNode,
+    node: &SyntaxNode,
     nix_file: &NixFile,
     relative_package_dir: &RelativePath,
     absolute_package_dir: &Path,
@@ -122,7 +123,7 @@ fn check_nix_path(
     let line = nix_file.line_index.line(node.text_range().start().into());
     let text = node.text().to_string();
     // We're only interested in Path expressions
-    let Some(path) = rnix::ast::Path::cast(node) else {
+    let Some(path) = rnix::ast::Path::cast(node.clone()) else {
         return Success(());
     };
 
@@ -160,6 +161,26 @@ fn check_nix_path(
         }
     }
 }
+fn check_nix_with(
+    node: &SyntaxNode,
+    nix_file: &NixFile,
+    _relative_package_dir: &RelativePath,
+    _absolute_package_dir: &Path,
+    subpath: &RelativePath,
+) -> validation::Validation<()> {
+    let _line = nix_file.line_index.line(node.text_range().start().into());
+    let _text = node.text().to_string();
+    // We're only interested in Path expressions
+    let Some(with) = rnix::ast::With::cast(node.clone()) else {
+        return Success(());
+    };
+    // let Some(with_body) = with.body() else {
+    //     return Success(());
+    // };
+    // println!("{}", with_body.syntax());
+
+    npv_169::TopLevelWithMayShadowVariablesAndBreakStaticChecks::new(subpath).into()
+}
 
 /// Check whether a Nix file contains path expression references pointing outside the package
 /// directory.
@@ -176,7 +197,17 @@ fn check_nix_file(
     Ok(validation::sequence_(
         nix_file.syntax_root.syntax().descendants().map(|node| {
             match check_nix_path(
-                node,
+                &node,
+                nix_file,
+                relative_package_dir,
+                absolute_package_dir,
+                subpath,
+            ) {
+                Success(()) => Success(()),
+                value => return value,
+            };
+            match check_nix_with(
+                &node,
                 nix_file,
                 relative_package_dir,
                 absolute_package_dir,