Skip to content

Commit 0e96ec3

Browse files
authored
Merge pull request #271510 from mfrischknecht/fix-haru-gawk-extension
gawkextlib.haru: fix compilation errors due to typos fixed in libharu
2 parents 465d5a5 + 93c3fc7 commit 0e96ec3

File tree

2 files changed

+75
-7
lines changed

2 files changed

+75
-7
lines changed
Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
diff --git a/haru/pdf.c b/haru/pdf.c
2+
index d16f573..3129427 100644
3+
--- a/haru/pdf.c
4+
+++ b/haru/pdf.c
5+
@@ -105,7 +105,7 @@ static awk_scalar_t HPDF_CS_PATTERN_node;
6+
/* LineCap */
7+
static awk_scalar_t HPDF_BUTT_END_node;
8+
static awk_scalar_t HPDF_ROUND_END_node;
9+
-static awk_scalar_t HPDF_PROJECTING_SCUARE_END_node;
10+
+static awk_scalar_t HPDF_PROJECTING_SQUARE_END_node;
11+
12+
/* _LineJoin */
13+
static awk_scalar_t HPDF_MITER_JOIN_node;
14+
@@ -248,7 +248,7 @@ static awk_scalar_t HPDF_ENCODER_UNKNOWN_node;
15+
/* ByteType */
16+
static awk_scalar_t HPDF_BYTE_TYPE_SINGLE_node;
17+
static awk_scalar_t HPDF_BYTE_TYPE_LEAD_node;
18+
-static awk_scalar_t HPDF_BYTE_TYPE_TRIAL_node;
19+
+static awk_scalar_t HPDF_BYTE_TYPE_TRAIL_node;
20+
static awk_scalar_t HPDF_BYTE_TYPE_UNKNOWN_node;
21+
22+
/* TextAlignment */
23+
@@ -308,7 +308,7 @@ static const struct varinit varinit[] = {
24+
ENTRY(HPDF_CS_PATTERN, 1)
25+
ENTRY(HPDF_BUTT_END, 1)
26+
ENTRY(HPDF_ROUND_END, 1)
27+
- ENTRY(HPDF_PROJECTING_SCUARE_END, 1)
28+
+ ENTRY(HPDF_PROJECTING_SQUARE_END, 1)
29+
ENTRY(HPDF_MITER_JOIN, 1)
30+
ENTRY(HPDF_ROUND_JOIN, 1)
31+
ENTRY(HPDF_BEVEL_JOIN, 1)
32+
@@ -417,7 +417,7 @@ static const struct varinit varinit[] = {
33+
ENTRY(HPDF_ENCODER_UNKNOWN, 1)
34+
ENTRY(HPDF_BYTE_TYPE_SINGLE, 1)
35+
ENTRY(HPDF_BYTE_TYPE_LEAD, 1)
36+
- ENTRY(HPDF_BYTE_TYPE_TRIAL, 1)
37+
+ ENTRY(HPDF_BYTE_TYPE_TRAIL, 1)
38+
ENTRY(HPDF_BYTE_TYPE_UNKNOWN, 1)
39+
ENTRY(HPDF_TALIGN_LEFT, 1)
40+
ENTRY(HPDF_TALIGN_RIGHT, 1)
41+
diff --git a/haru/pdf.h b/haru/pdf.h
42+
index a4ef39a..07cf168 100644
43+
--- a/haru/pdf.h
44+
+++ b/haru/pdf.h
45+
@@ -86,7 +86,7 @@
46+
47+
#define DEFAULT_HPDF_BUTT_END HPDF_BUTT_END
48+
#define DEFAULT_HPDF_ROUND_END HPDF_ROUND_END
49+
-#define DEFAULT_HPDF_PROJECTING_SCUARE_END HPDF_PROJECTING_SCUARE_END
50+
+#define DEFAULT_HPDF_PROJECTING_SQUARE_END HPDF_PROJECTING_SQUARE_END
51+
52+
/* _LineJoin */
53+
#define DEFAULT_HPDF_MITER_JOIN HPDF_MITER_JOIN
54+
@@ -229,7 +229,7 @@
55+
/* ByteType */
56+
#define DEFAULT_HPDF_BYTE_TYPE_SINGLE HPDF_BYTE_TYPE_SINGLE
57+
#define DEFAULT_HPDF_BYTE_TYPE_LEAD HPDF_BYTE_TYPE_LEAD
58+
-#define DEFAULT_HPDF_BYTE_TYPE_TRIAL HPDF_BYTE_TYPE_TRIAL
59+
+#define DEFAULT_HPDF_BYTE_TYPE_TRAIL HPDF_BYTE_TYPE_TRAIL
60+
#define DEFAULT_HPDF_BYTE_TYPE_UNKNOWN HPDF_BYTE_TYPE_UNKNOWN
61+
62+
/* TextAlignment */

pkgs/tools/text/gawk/gawkextlib.nix

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
let
77
buildExtension = lib.makeOverridable
8-
({ name, gawkextlib, extraBuildInputs ? [ ], doCheck ? true }:
8+
({ name, gawkextlib, extraBuildInputs ? [ ], doCheck ? true, patches ? [ ] }:
99
let is_extension = gawkextlib != null;
1010
in stdenv.mkDerivation rec {
1111
pname = "gawkextlib-${name}";
@@ -17,6 +17,8 @@ let
1717
sha256 = "sha256-0p3CrQ3TBl7UcveZytK/9rkAzn69RRM2GwY2eCeqlkg=";
1818
};
1919

20+
inherit patches;
21+
2022
postPatch = ''
2123
cd ${name}
2224
'';
@@ -83,12 +85,16 @@ let
8385
name = "gd";
8486
extraBuildInputs = [ gd ];
8587
};
86-
# Build has been broken: https://github.com/NixOS/nixpkgs/issues/191072
87-
# haru = buildExtension {
88-
# inherit gawkextlib;
89-
# name = "haru";
90-
# extraBuildInputs = [ libharu ];
91-
# };
88+
haru = buildExtension {
89+
inherit gawkextlib;
90+
name = "haru";
91+
extraBuildInputs = [ libharu ];
92+
patches = [
93+
# Renames references to two identifiers with typos that libharu fixed in 2.4.4
94+
# https://github.com/libharu/libharu/commit/88271b73c68c521a49a15e3555ef00395aa40810
95+
./fix-typos-corrected-in-libharu-2.4.4.patch
96+
];
97+
};
9298
json = buildExtension {
9399
inherit gawkextlib;
94100
name = "json";

0 commit comments

Comments
 (0)