Skip to content

Commit 17aacfb

Browse files
authored
mpiCheckPhaseHook: disable openmpi's ssh plugin (#351473)
2 parents 4716ada + 1727761 commit 17aacfb

File tree

10 files changed

+11
-24
lines changed

10 files changed

+11
-24
lines changed

pkgs/build-support/setup-hooks/mpi-check-hook/mpi-check-hook.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ setupMpiCheck() {
66
# Find out which MPI implementation we are using
77
# and set safe defaults that are guaranteed to run
88
# on any build machine
9-
109
mpiType="NONE"
1110

1211
# OpenMPI signature
@@ -41,6 +40,10 @@ setupMpiCheck() {
4140
export OMPI_MCA_rmaps_base_oversubscribe=1
4241
export PRTE_MCA_rmaps_default_mapping_policy=node:oversubscribe
4342

43+
# Make sure we do not need openssh in the checkPhase
44+
export OMPI_MCA_plm_ssh_agent=false
45+
export PRRTE_MCA_plm_ssh_agent=false
46+
4447
# Disable CPU pinning
4548
export OMPI_MCA_hwloc_base_binding_policy=none
4649
export PRTE_MCA_hwloc_default_binding_policy=none

pkgs/by-name/cp/cp2k/package.nix

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
mpi,
1919
gsl,
2020
scalapack,
21-
openssh,
2221
makeWrapper,
2322
libxsmm,
2423
spglib,
@@ -83,7 +82,6 @@ stdenv.mkDerivation rec {
8382
nativeBuildInputs = [
8483
python3
8584
which
86-
openssh
8785
makeWrapper
8886
pkg-config
8987
] ++ lib.optional (gpuBackend == "cuda") cudaPackages.cuda_nvcc;
@@ -225,7 +223,6 @@ stdenv.mkDerivation rec {
225223

226224
nativeCheckInputs = [
227225
mpiCheckPhaseHook
228-
openssh
229226
];
230227

231228
checkPhase = ''

pkgs/by-name/pe/petsc/package.nix

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
mpiSupport ? true,
1111
mpi, # generic mpi dependency
1212
mpiCheckPhaseHook,
13-
openssh, # required for openmpi tests
1413
petsc-withp4est ? false,
1514
hdf5-support ? false,
1615
hdf5,
@@ -42,7 +41,7 @@ stdenv.mkDerivation rec {
4241
python3
4342
gfortran
4443
pkg-config
45-
] ++ lib.optional mpiSupport mpi ++ lib.optional (mpiSupport && mpi.pname == "openmpi") openssh;
44+
] ++ lib.optional mpiSupport mpi;
4645
buildInputs = [
4746
blas
4847
lapack

pkgs/by-name/si/sirius/package.nix

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
, pkg-config
66
, mpi
77
, mpiCheckPhaseHook
8-
, openssh
98
, gfortran
109
, blas
1110
, lapack
@@ -139,7 +138,6 @@ stdenv.mkDerivation rec {
139138

140139
nativeCheckInputs = [
141140
mpiCheckPhaseHook
142-
openssh
143141
];
144142

145143
meta = with lib; {

pkgs/development/libraries/elpa/default.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{ lib, stdenv, fetchurl, autoreconfHook, mpiCheckPhaseHook
2-
, perl, mpi, blas, lapack, scalapack, openssh
2+
, perl, mpi, blas, lapack, scalapack
33
# CPU optimizations
44
, avxSupport ? stdenv.hostPlatform.avxSupport
55
, avx2Support ? stdenv.hostPlatform.avx2Support
@@ -84,7 +84,7 @@ stdenv.mkDerivation rec {
8484

8585
doCheck = !enableCuda;
8686

87-
nativeCheckInputs = [ mpiCheckPhaseHook openssh ];
87+
nativeCheckInputs = [ mpiCheckPhaseHook ];
8888
preCheck = ''
8989
#patchShebangs ./
9090

pkgs/development/libraries/science/math/dbcsr/default.nix

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
, python3
1212
, libxsmm
1313
, mpi
14-
, openssh
1514
}:
1615

1716
stdenv.mkDerivation rec {
@@ -62,7 +61,6 @@ stdenv.mkDerivation rec {
6261
];
6362

6463
checkInputs = [
65-
openssh
6664
mpiCheckPhaseHook
6765
];
6866

pkgs/development/libraries/science/math/p4est-sc/default.nix

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
{ lib, stdenv, fetchFromGitHub, mpiCheckPhaseHook
22
, autoreconfHook, pkg-config
33
, p4est-sc-debugEnable ? true, p4est-sc-mpiSupport ? true
4-
, mpi, openssh, zlib
4+
, mpi, zlib
55
}:
66

77
let
88
dbg = lib.optionalString debugEnable "-dbg";
99
debugEnable = p4est-sc-debugEnable;
1010
mpiSupport = p4est-sc-mpiSupport;
11-
isOpenmpi = mpiSupport && mpi.pname == "openmpi";
1211
in
1312
stdenv.mkDerivation {
1413
pname = "p4est-sc${dbg}";
@@ -24,9 +23,7 @@ stdenv.mkDerivation {
2423

2524
strictDeps = true;
2625
nativeBuildInputs = [ autoreconfHook pkg-config ];
27-
propagatedNativeBuildInputs = lib.optional mpiSupport mpi
28-
++ lib.optional isOpenmpi openssh
29-
;
26+
propagatedNativeBuildInputs = lib.optional mpiSupport mpi ;
3027
propagatedBuildInputs = [ zlib ];
3128
inherit debugEnable mpiSupport;
3229

@@ -49,7 +46,6 @@ stdenv.mkDerivation {
4946

5047
nativeCheckInputs = lib.optionals mpiSupport [
5148
mpiCheckPhaseHook
52-
openssh
5349
];
5450

5551
# disallow Darwin checks due to prototype incompatibility of qsort_r

pkgs/development/libraries/science/math/scalapack/default.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{ lib, stdenv, fetchFromGitHub, fetchpatch, cmake
2-
, openssh, mpiCheckPhaseHook, mpi, blas, lapack
2+
, mpiCheckPhaseHook, mpi, blas, lapack
33
} :
44

55
assert blas.isILP64 == lapack.isILP64;
@@ -39,7 +39,7 @@ stdenv.mkDerivation rec {
3939
outputs = [ "out" "dev" ];
4040

4141
nativeBuildInputs = [ cmake ];
42-
nativeCheckInputs = [ openssh mpiCheckPhaseHook ];
42+
nativeCheckInputs = [ mpiCheckPhaseHook ];
4343
buildInputs = [ blas lapack ];
4444
propagatedBuildInputs = [ mpi ];
4545
hardeningDisable = lib.optionals (stdenv.hostPlatform.isAarch64 && stdenv.hostPlatform.isDarwin) [ "stackprotector" ];

pkgs/development/python-modules/meep/default.nix

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
harminv,
1919
libctl,
2020
libGDSII,
21-
openssh,
2221
guile,
2322
python,
2423
numpy,
@@ -124,7 +123,6 @@ buildPythonPackage rec {
124123
*/
125124
nativeCheckInputs = [
126125
mpiCheckPhaseHook
127-
openssh
128126
];
129127
checkPhase = ''
130128
runHook preCheck

pkgs/development/python-modules/mpi4py/default.nix

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
cython,
66
setuptools,
77
mpi,
8-
openssh,
98
pytestCheckHook,
109
mpiCheckPhaseHook,
1110
}:
@@ -35,7 +34,6 @@ buildPythonPackage rec {
3534

3635
nativeCheckInputs = [
3736
pytestCheckHook
38-
openssh
3937
mpiCheckPhaseHook
4038
];
4139
doCheck = true;

0 commit comments

Comments
 (0)