ida-free: 8.4.240320 -> 9.0sp1 (#382513)

Author: msanft

pkgs/by-name/id/ida-free/package.nix

@@ -1,7 +1,6 @@
 {
   autoPatchelfHook,
   cairo,
-  copyDesktopItems,
   dbus,
   fetchurl,
   fontconfig,
@@ -16,51 +15,24 @@
   libsForQt5,
   libunwind,
   libxkbcommon,
-  makeDesktopItem,
   makeWrapper,
   openssl,
   stdenv,
   xorg,
   zlib,
 }:
 
-let
-  srcs = builtins.fromJSON (builtins.readFile ./srcs.json);
-in
 stdenv.mkDerivation rec {
   pname = "ida-free";
-  version = "8.4.240320";
+  version = "9.0sp1";
 
   src = fetchurl {
-    inherit (srcs.${stdenv.system} or (throw "Unsupported system: ${stdenv.hostPlatform.system}"))
-      urls
-      sha256
-      ;
+    url = "https://archive.org/download/ida-free-pc_90sp1_x64linux/ida-free-pc_90sp1_x64linux.run";
+    hash = "sha256-e5uCcJVn6xDwmVm14QCBUvNcB1MpVxNA2WcLyuK23vo=";
   };
 
-  icon = fetchurl {
-    urls = [
-      "https://web.archive.org/web/20221105181231if_/https://hex-rays.com/products/ida/news/8_1/images/icon_free.png"
-    ];
-    hash = "sha256-widkv2VGh+eOauUK/6Sz/e2auCNFAsc8n9z0fdrSnW0=";
-  };
-
-  desktopItem = makeDesktopItem {
-    name = "ida-free";
-    exec = "ida64";
-    icon = icon;
-    comment = meta.description;
-    desktopName = "IDA Free";
-    genericName = "Interactive Disassembler";
-    categories = [ "Development" ];
-    startupWMClass = "IDA";
-  };
-
-  desktopItems = [ desktopItem ];
-
   nativeBuildInputs = [
     makeWrapper
-    copyDesktopItems
     autoPatchelfHook
     libsForQt5.wrapQtAppsHook
   ];
@@ -107,31 +79,39 @@ stdenv.mkDerivation rec {
     runHook preInstall
 
     mkdir -p $out/bin $out/lib $out/opt
+    mkdir -p $out/.local/share/applications
 
     # IDA depends on quite some things extracted by the runfile, so first extract everything
     # into $out/opt, then remove the unnecessary files and directories.
     IDADIR=$out/opt
 
+    # The installer doesn't honor `--prefix` in all places,
+    # thus needing to set `HOME` here.
+    HOME=$out
+
     # Invoke the installer with the dynamic loader directly, avoiding the need
     # to copy it to fix permissions and patch the executable.
     $(cat $NIX_CC/nix-support/dynamic-linker) $src \
-      --mode unattended --prefix $IDADIR --installpassword ""
+      --mode unattended --prefix $IDADIR
 
     # Copy the exported libraries to the output.
-    cp $IDADIR/libida64.so $out/lib
+    cp $IDADIR/libida.so $out/lib
 
     # Some libraries come with the installer.
     addAutoPatchelfSearchPath $IDADIR
 
-    for bb in ida64 assistant; do
+    for bb in ida assistant; do
       wrapProgram $IDADIR/$bb \
         --prefix QT_PLUGIN_PATH : $IDADIR/plugins/platforms
       ln -s $IDADIR/$bb $out/bin/$bb
     done
 
     # runtimeDependencies don't get added to non-executables, and openssl is needed
     #  for cloud decompilation
-    patchelf --add-needed libcrypto.so $IDADIR/libida64.so
+    patchelf --add-needed libcrypto.so $IDADIR/libida.so
+
+    mv $out/.local/share $out
+    rm -r $out/.local
 
     runHook postInstall
   '';
@@ -141,7 +121,7 @@ stdenv.mkDerivation rec {
     homepage = "https://hex-rays.com/ida-free/";
     changelog = "https://hex-rays.com/products/ida/news/";
     license = licenses.unfree;
-    mainProgram = "ida64";
+    mainProgram = "ida";
     maintainers = with maintainers; [ msanft ];
     platforms = [ "x86_64-linux" ]; # Right now, the installation script only supports Linux.
     sourceProvenance = with sourceTypes; [ binaryNativeCode ];