fex: cleanup (#396617)

Author: GaetanLepage

pkgs/by-name/fe/fex/package.nix

@@ -1,22 +1,23 @@
 {
-  fetchFromGitHub,
   lib,
   llvmPackages,
+  fetchFromGitHub,
   cmake,
   ninja,
   pkg-config,
   qt5,
   python3,
+  nix-update-script,
 }:
 
-llvmPackages.stdenv.mkDerivation (finalAttrs: rec {
+llvmPackages.stdenv.mkDerivation (finalAttrs: {
   pname = "fex";
   version = "2504";
 
   src = fetchFromGitHub {
     owner = "FEX-Emu";
     repo = "FEX";
-    tag = "FEX-${version}";
+    tag = "FEX-${finalAttrs.version}";
     hash = "sha256-tqUJBHYSRlEUaLI4WItzotIHGMUNbdjA7o9NjBYZmHw=";
     fetchSubmodules = true;
   };
@@ -44,10 +45,10 @@ llvmPackages.stdenv.mkDerivation (finalAttrs: rec {
   ];
 
   cmakeFlags = [
-    "-DCMAKE_BUILD_TYPE=Release"
-    "-DUSE_LINKER=lld"
-    "-DENABLE_LTO=True"
-    "-DENABLE_ASSERTIONS=False"
+    (lib.cmakeFeature "CMAKE_BUILD_TYPE" "Release")
+    (lib.cmakeFeature "USE_LINKER" "lld")
+    (lib.cmakeBool "ENABLE_LTO" true)
+    (lib.cmakeBool "ENABLE_ASSERTIONS" false)
     (lib.cmakeFeature "OVERRIDE_VERSION" finalAttrs.version)
     (lib.cmakeBool "BUILD_TESTS" finalAttrs.finalPackage.doCheck)
   ];
@@ -62,9 +63,14 @@ llvmPackages.stdenv.mkDerivation (finalAttrs: rec {
     wrapQtApp $out/bin/FEXConfig
   '';
 
+  passthru = {
+    updateScript = nix-update-script { };
+  };
+
   meta = {
     description = "Fast usermode x86 and x86-64 emulator for Arm64 Linux";
     homepage = "https://fex-emu.com/";
+    changelog = "https://github.com/FEX-Emu/FEX/releases/tag/FEX-${finalAttrs.version}";
     platforms = [ "aarch64-linux" ];
     license = lib.licenses.mit;
     maintainers = with lib.maintainers; [ andre4ik3 ];