frigate: centralize the ffmpeg flavor selection in the module

In 0.16.0 frigate added a config option to pass an ffmpeg build for the
ffmpeg and ffprobe executables.

Previously we unconditionally patched in ffmpeg-headless, which has now
been changed to use the `ffmpeg.path` provided build, so that we don't
bloat the closure with multiple ffmpegs or don't require overriding the
package to select another version.

In contrast to the upstream configuration we only accept packages and not
the "default" string, because that would have complicated the logic
needlessly.

Author: mweinelt

nixos/modules/services/video/frigate.nix

@@ -231,6 +231,17 @@ in
             };
           };
 
+          ffmpeg = {
+            path = mkOption {
+              type = coercedTo package toString str;
+              default = pkgs.ffmpeg-headless;
+              example = literalExpression "pkgs.ffmpeg-full";
+              description = ''
+                Package providing the ffmpeg and ffprobe executables below the bin/ directory.
+              '';
+            };
+          };
+
           mqtt = {
             enabled = mkEnableOption "MQTT support";
 

pkgs/by-name/fr/frigate/ffmpeg.patch

@@ -1,39 +1,47 @@
 diff --git a/frigate/config/camera/ffmpeg.py b/frigate/config/camera/ffmpeg.py
-index 04bbfac7..4390a571 100644
+index 04bbfac7..396bcc4b 100644
 --- a/frigate/config/camera/ffmpeg.py
 +++ b/frigate/config/camera/ffmpeg.py
-@@ -70,18 +70,14 @@ class FfmpegConfig(FrigateBaseModel):
+@@ -1,4 +1,5 @@
+ from enum import Enum
++from os.path import join
+ from typing import Union
+ 
+ from pydantic import Field, field_validator
+@@ -69,21 +70,11 @@ class FfmpegConfig(FrigateBaseModel):
+ 
      @property
      def ffmpeg_path(self) -> str:
-         if self.path == "default":
+-        if self.path == "default":
 -            return f"/usr/lib/ffmpeg/{DEFAULT_FFMPEG_VERSION}/bin/ffmpeg"
 -        elif self.path in INCLUDED_FFMPEG_VERSIONS:
 -            return f"/usr/lib/ffmpeg/{self.path}/bin/ffmpeg"
-+            return "@ffmpeg@"
-         else:
-             return f"{self.path}/bin/ffmpeg"
+-        else:
+-            return f"{self.path}/bin/ffmpeg"
++        return join(self.path, "bin/ffmpeg")
 
      @property
      def ffprobe_path(self) -> str:
-         if self.path == "default":
+-        if self.path == "default":
 -            return f"/usr/lib/ffmpeg/{DEFAULT_FFMPEG_VERSION}/bin/ffprobe"
 -        elif self.path in INCLUDED_FFMPEG_VERSIONS:
 -            return f"/usr/lib/ffmpeg/{self.path}/bin/ffprobe"
-+            return "@ffprobe@"
-         else:
-             return f"{self.path}/bin/ffprobe"
+-        else:
+-            return f"{self.path}/bin/ffprobe"
++        return join(self.path, "bin/ffprobe")
+ 
 
+ class CameraRoleEnum(str, Enum):
 diff --git a/frigate/record/export.py b/frigate/record/export.py
-index 0d3f96da..09cadbcd 100644
+index 0d3f96da..463bcff4 100644
 --- a/frigate/record/export.py
 +++ b/frigate/record/export.py
 @@ -126,7 +126,7 @@ class RecordingExporter(threading.Thread):
              minutes = int(diff / 60)
              seconds = int(diff % 60)
              ffmpeg_cmd = [
 -                "/usr/lib/ffmpeg/7.0/bin/ffmpeg",  # hardcode path for exports thumbnail due to missing libwebp support
-+                "@ffmpeg@",  # hardcode path for exports thumbnail due to missing libwebp support
++                FfmpegConfig.ffmpeg_path,  # hardcode path for exports thumbnail due to missing libwebp support
                  "-hide_banner",
                  "-loglevel",
                  "warning",
-~

pkgs/by-name/fr/frigate/package.nix

@@ -2,7 +2,6 @@
   lib,
   stdenv,
   callPackage,
-  replaceVars,
   python312Packages,
   fetchFromGitHub,
   fetchurl,
@@ -78,11 +77,7 @@ python3Packages.buildPythonApplication rec {
 
   patches = [
     ./constants.patch
-
-    (replaceVars ./ffmpeg.patch {
-      ffmpeg = lib.getExe ffmpeg-headless;
-      ffprobe = lib.getExe' ffmpeg-headless "ffprobe";
-    })
+    ./ffmpeg.patch
   ];
 
   postPatch = ''
@@ -205,6 +200,7 @@ python3Packages.buildPythonApplication rec {
   '';
 
   nativeCheckInputs = with python3Packages; [
+    ffmpeg-headless
     pytestCheckHook
   ];