Skip to content

Commit 6da24bc

Browse files
committed
python312Packages.plotly: cleanup, enable checks on darwin
1 parent 6c21cff commit 6da24bc

File tree

1 file changed

+17
-49
lines changed

1 file changed

+17
-49
lines changed

pkgs/development/python-modules/plotly/default.nix

Lines changed: 17 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,10 @@
1414
xarray,
1515
pillow,
1616
scipy,
17-
psutil,
1817
statsmodels,
1918
ipython,
2019
ipywidgets,
2120
which,
22-
orca,
2321
nbformat,
2422
scikit-image,
2523
}:
@@ -61,69 +59,39 @@ buildPythonPackage rec {
6159
xarray
6260
pillow
6361
scipy
64-
psutil
6562
statsmodels
6663
ipython
6764
ipywidgets
6865
which
69-
orca
7066
nbformat
7167
scikit-image
7268
];
7369

74-
# the check inputs are broken on darwin
75-
doCheck = !stdenv.hostPlatform.isDarwin;
76-
7770
disabledTests = [
78-
# FAILED plotly/matplotlylib/mplexporter/tests/test_basic.py::test_legend_dots - AssertionError: assert '3' == '2'
71+
# failed pinning test, sensitive to dep versions
7972
"test_legend_dots"
80-
# FAILED plotly/matplotlylib/mplexporter/tests/test_utils.py::test_linestyle - AssertionError:
8173
"test_linestyle"
82-
# FAILED plotly/tests/test_io/test_to_from_plotly_json.py::test_sanitize_json[auto] - KeyError: 'template'
83-
# FAILED plotly/tests/test_io/test_to_from_plotly_json.py::test_sanitize_json[json] - KeyError: 'template'
74+
# test bug, i assume sensitive to dep versions
8475
"test_sanitize_json"
85-
# FAILED plotly/tests/test_orca/test_orca_server.py::test_validate_orca - ValueError:
86-
"test_validate_orca"
87-
# FAILED plotly/tests/test_orca/test_orca_server.py::test_orca_executable_path - ValueError:
88-
"test_orca_executable_path"
89-
# FAILED plotly/tests/test_orca/test_orca_server.py::test_orca_version_number - ValueError:
90-
"test_orca_version_number"
91-
# FAILED plotly/tests/test_orca/test_orca_server.py::test_ensure_orca_ping_and_proc - ValueError:
92-
"test_ensure_orca_ping_and_proc"
93-
# FAILED plotly/tests/test_orca/test_orca_server.py::test_server_timeout_shutdown - ValueError:
94-
"test_server_timeout_shutdown"
95-
# FAILED plotly/tests/test_orca/test_orca_server.py::test_external_server_url - ValueError:
96-
"test_external_server_url"
97-
# FAILED plotly/tests/test_orca/test_to_image.py::test_simple_to_image[eps] - ValueError:
98-
"test_simple_to_image"
99-
# FAILED plotly/tests/test_orca/test_to_image.py::test_to_image_default[eps] - ValueError:
100-
"test_to_image_default"
101-
# FAILED plotly/tests/test_orca/test_to_image.py::test_write_image_string[eps] - ValueError:
102-
"test_write_image_string"
103-
# FAILED plotly/tests/test_orca/test_to_image.py::test_write_image_writeable[eps] - ValueError:
104-
"test_write_image_writeable"
105-
# FAILED plotly/tests/test_orca/test_to_image.py::test_write_image_string_format_inference[eps] - ValueError:
106-
"test_write_image_string_format_inference"
107-
# FAILED plotly/tests/test_orca/test_to_image.py::test_write_image_string_bad_extension_failure - assert 'must be specified as one of the followi...
108-
"test_write_image_string_bad_extension_failure"
109-
# FAILED plotly/tests/test_orca/test_to_image.py::test_write_image_string_bad_extension_override - ValueError:
110-
"test_write_image_string_bad_extension_override"
111-
# FAILED plotly/tests/test_orca/test_to_image.py::test_topojson_fig_to_image[eps] - ValueError:
112-
"test_topojson_fig_to_image"
113-
# FAILED plotly/tests/test_orca/test_to_image.py::test_latex_fig_to_image[eps] - ValueError:
114-
"test_latex_fig_to_image"
115-
# FAILED plotly/tests/test_orca/test_to_image.py::test_problematic_environment_variables[eps] - ValueError:
116-
"test_problematic_environment_variables"
117-
# FAILED plotly/tests/test_orca/test_to_image.py::test_invalid_figure_json - assert 'Invalid' in "\nThe orca executable is required in order to e...
118-
"test_invalid_figure_json"
119-
# FAILED test_init/test_dependencies_not_imported.py::test_dependencies_not_imported - AssertionError: assert 'plotly' not in {'IPython': <module>
120-
"test_dependencies_not_imported"
121-
# FAILED test_init/test_lazy_imports.py::test_lazy_imports - AssertionError: assert 'plotly' not in {'IPython': <module 'IPython' from '...
122-
"test_lazy_imports"
12376
# requires vaex and polars, vaex is not packaged
12477
"test_build_df_from_vaex_and_polars"
12578
"test_build_df_with_hover_data_from_vaex_and_polars"
79+
# lazy loading error, could it be the sandbox PYTHONPATH?
80+
# AssertionError: assert "plotly" not in sys.modules
81+
"test_dependencies_not_imported"
82+
"test_lazy_imports"
12683
];
84+
disabledTestPaths =
85+
[
86+
# unable to locate orca binary, adding the package does not fix it
87+
"plotly/tests/test_orca/"
88+
]
89+
++ lib.optionals stdenv.hostPlatform.isDarwin [
90+
# requires local networking
91+
"plotly/tests/test_io/test_renderers.py"
92+
# fails to launch kaleido subprocess
93+
"plotly/tests/test_optional/test_kaleido"
94+
];
12795

12896
pythonImportsCheck = [ "plotly" ];
12997

0 commit comments

Comments
 (0)