nixos/torsocks: do not enable when tor client functionality is used (#426419)

Author: SuperSandro2000

nixos/doc/manual/release-notes/rl-2511.section.md

@@ -150,6 +150,8 @@
 
 - The `services.siproxd` module has been removed as `siproxd` is unmaintained and broken with libosip 5.x.
 
+- `services.tor.torsocks.enable` no longer defaults to true if Tor and Tor client functionality is enabled.
+
 - `netbox-manage` script created by the `netbox` module no longer uses `sudo -u netbox` internally. It can be run as root and will change it's user to `netbox` using `runuser`
 
 - `services.gateone` has been removed as the package was removed such that it does not work.

nixos/modules/services/security/torsocks.nix

@@ -38,8 +38,7 @@ in
     services.tor.torsocks = {
       enable = lib.mkOption {
         type = lib.types.bool;
-        default = config.services.tor.enable && config.services.tor.client.enable;
-        defaultText = lib.literalExpression "config.services.tor.enable && config.services.tor.client.enable";
+        default = false;
         description = ''
           Whether to build `/etc/tor/torsocks.conf`
           containing the specified global torsocks configuration.