Skip to content

Commit 8611672

Browse files
TomaSajtJohnRTitor
authored andcommitted
Revert "electron-bin: don't wrap inside libexec"
This reverts commit aa3ba4c.
1 parent 807a57f commit 8611672

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

pkgs/development/tools/electron/binary/generic.nix

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -157,21 +157,25 @@ let
157157
chmod u-x $out/libexec/electron/*.so*
158158
'';
159159

160-
# We don't want to wrap the contents of $out/libexec automatically
161-
dontWrapGApps = true;
162-
163-
preFixup = ''
164-
makeWrapper "$out/libexec/electron/electron" $out/bin/electron \
165-
"''${gappsWrapperArgs[@]}" \
166-
${lib.optionalString needsAarch64PageSizeFix "--add-flags '--js-flags=--no-decommit-pooled-pages'"}
167-
'';
160+
# We use null here to not cause unnecessary rebuilds.
161+
dontWrapGApps = if needsAarch64PageSizeFix then true else null;
162+
preFixup =
163+
if needsAarch64PageSizeFix then
164+
''
165+
wrapProgram "$out/libexec/electron/chrome_crashpad_handler" "''${gappsWrapperArgs[@]}"
166+
wrapProgram "$out/libexec/electron/chrome-sandbox" "''${gappsWrapperArgs[@]}"
167+
wrapProgram "$out/libexec/electron/electron" "''${gappsWrapperArgs[@]}" \
168+
--add-flags "--js-flags=--no-decommit-pooled-pages"
169+
''
170+
else
171+
null;
168172

169173
postFixup = ''
170174
patchelf \
171175
--set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
172176
--set-rpath "${electronLibPath}:$out/libexec/electron" \
173-
$out/libexec/electron/electron \
174-
$out/libexec/electron/chrome_crashpad_handler
177+
$out/libexec/electron/.electron-wrapped \
178+
$out/libexec/electron/.chrome_crashpad_handler-wrapped
175179
176180
# patch libANGLE
177181
patchelf \

0 commit comments

Comments
 (0)