Skip to content

Commit 8ceb7ca

Browse files
committed
python312Packages.ipylab: fix broken 'ipylab._version' import
Running hatchling without the version hook prevents this file from being created, which causes an import error on Darwin. The second hook, one that normally compiles javascript is skipped, as our sources already contain it, yet the declared dependency, hatch-jupyter-builder still needs to be provided.
1 parent e57fd6a commit 8ceb7ca

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

pkgs/development/python-modules/ipylab/default.nix

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
buildPythonPackage,
44
fetchPypi,
55
hatchling,
6+
hatch-jupyter-builder,
67
hatch-nodejs-version,
78
ipywidgets,
89
jupyterlab,
@@ -13,19 +14,20 @@ buildPythonPackage rec {
1314
version = "1.0.0";
1415
pyproject = true;
1516

17+
# This needs to be fetched from Pypi, as we rely on the nodejs build to be skipped,
18+
# which only happens if ipylab/labextension/style.js is present.
1619
src = fetchPypi {
1720
inherit pname version;
1821
hash = "sha256-xPB0Sx+W1sRgW5hqpZ68zWRFG/cclIOgGat6UsVlYXA=";
1922
};
2023

2124
build-system = [
2225
hatchling
26+
hatch-jupyter-builder
2327
hatch-nodejs-version
2428
jupyterlab
2529
];
2630

27-
env.HATCH_BUILD_NO_HOOKS = true;
28-
2931
dependencies = [
3032
ipywidgets
3133
];
@@ -41,10 +43,5 @@ buildPythonPackage rec {
4143
changelog = "https://github.com/jtpio/ipylab/releases/tag/v${version}";
4244
license = lib.licenses.bsd3;
4345
maintainers = with lib.maintainers; [ flokli ];
44-
badPlatforms = [
45-
# Unclear why it breaks on darwin only
46-
# ModuleNotFoundError: No module named 'ipylab._version'
47-
lib.systems.inspect.patterns.isDarwin
48-
];
4946
};
5047
}

0 commit comments

Comments
 (0)