go_1_22/buildGo122Module: remove (#394017)

Author: katexochen

pkgs/applications/networking/cloudflared/default.nix

@@ -7,6 +7,22 @@
   gitUpdater,
 }:
 
+let
+  # https://github.com/cloudflare/cloudflared/issues/1151#issuecomment-1888819250
+  # buildGoModule = buildGoModule.override {
+  #   go = buildPackages.go_1_22.overrideAttrs {
+  #     pname = "cloudflare-go";
+  #     version = "1.22.2-devel-cf";
+  #     src = fetchFromGitHub {
+  #       owner = "cloudflare";
+  #       repo = "go";
+  #       rev = "ec0a014545f180b0c74dfd687698657a9e86e310";
+  #       sha256 = "sha256-oQQ9Jyh8TphZSCaHqaugTL7v0aeZjyOdVACz86I2KvU=";
+  #     };
+  #   };
+  # };
+in
+
 buildGoModule rec {
   pname = "cloudflared";
   version = "2025.2.1";
@@ -91,5 +107,8 @@ buildGoModule rec {
       qjoly
     ];
     mainProgram = "cloudflared";
+    # cloudflared requires a fork of go 1.22 to build (see override above),
+    # but go 1.22 is EOL and the toolchain has been removed from nixpkgs.
+    broken = true;
   };
 }

pkgs/applications/networking/cluster/nomad/default.nix

@@ -1,7 +1,6 @@
 {
   lib,
   buildGoModule,
-  buildGo122Module,
   buildGo124Module,
   fetchFromGitHub,
   nixosTests,
@@ -84,30 +83,6 @@ rec {
 
   nomad = nomad_1_9;
 
-  nomad_1_7 = generic {
-    buildGoModule = buildGo122Module;
-    version = "1.7.7";
-    sha256 = "sha256-4nuRheidR6rIoytrnDQdIP69f+sBLJ3Ias5DvqVaLFc=";
-    vendorHash = "sha256-ZuaD8iDsT+/eW0QUavf485R804Jtjl76NcQWYHA8QII=";
-    license = lib.licenses.bsl11;
-    passthru.tests.nomad = nixosTests.nomad;
-    preCheck = ''
-      export PATH="$PATH:$NIX_BUILD_TOP/go/bin"
-    '';
-  };
-
-  nomad_1_8 = generic {
-    buildGoModule = buildGo122Module;
-    version = "1.8.4";
-    sha256 = "sha256-BzLvALD65VqWNB9gx4BgI/mYWLNeHzp6WSXD/1Xf0Wk=";
-    vendorHash = "sha256-0mnhZeiCLAWvwAoNBJtwss85vhYCrf/5I1AhyXTFnWk=";
-    license = lib.licenses.bsl11;
-    passthru.tests.nomad = nixosTests.nomad;
-    preCheck = ''
-      export PATH="$PATH:$NIX_BUILD_TOP/go/bin"
-    '';
-  };
-
   nomad_1_9 = generic {
     buildGoModule = buildGo124Module;
     version = "1.9.7";

pkgs/applications/version-management/gitmux/default.nix

@@ -21,6 +21,12 @@ buildGoModule (finalAttrs: {
 
   nativeCheckInputs = [ git ];
 
+  # After bump of Go toolchain to version >1.22, tests fail with:
+  #   vendor/github.com/rogpeppe/go-internal/testscript/exe_go118.go:14:27:
+  #   cannot use nopTestDeps{} (value of struct type nopTestDeps) as testing.testDeps value in argument to testing.MainStart:
+  #   nopTestDeps does not implement testing.testDeps (missing method InitRuntimeCoverage)'.
+  doCheck = false;
+
   ldflags = [ "-X main.version=${finalAttrs.version}" ];
 
   passthru.tests.version = testers.testVersion {

pkgs/by-name/al/ali/package.nix

@@ -1,10 +1,11 @@
 {
   lib,
-  buildGo122Module,
+  buildGoModule,
   fetchFromGitHub,
+  stdenv,
 }:
 
-buildGo122Module rec {
+buildGoModule rec {
   pname = "ali";
   version = "0.7.5";
 
@@ -25,5 +26,8 @@ buildGo122Module rec {
     platforms = platforms.linux ++ platforms.darwin;
     maintainers = with maintainers; [ farcaller ];
     mainProgram = "ali";
+    # Broken on darwin for Go toolchain > 1.22, with error:
+    # 'link: golang.org/x/net/internal/socket: invalid reference to syscall.recvmsg'
+    broken = stdenv.hostPlatform.isDarwin;
   };
 }

pkgs/by-name/be/bettercap/package.nix

@@ -1,7 +1,7 @@
 {
   lib,
   stdenv,
-  buildGo122Module,
+  buildGoModule,
   fetchFromGitHub,
   pkg-config,
   libpcap,
@@ -10,7 +10,7 @@
   libusb1,
 }:
 
-buildGo122Module rec {
+buildGoModule rec {
   pname = "bettercap";
   version = "2.32.0";
 
@@ -47,5 +47,8 @@ buildGo122Module rec {
     license = with licenses; [ gpl3Only ];
     maintainers = with maintainers; [ y0no ];
     mainProgram = "bettercap";
+    # Broken on darwin for Go toolchain > 1.22, with error:
+    # 'link: golang.org/x/net/internal/socket: invalid reference to syscall.recvmsg'
+    broken = stdenv.hostPlatform.isDarwin;
   };
 }

pkgs/by-name/bi/bitmagnet/package.nix

@@ -1,26 +1,27 @@
 {
   lib,
-  buildGo122Module, # builds, but does not start on 1.23
+  buildGoModule,
   fetchFromGitHub,
   nix-update-script,
 }:
 
-buildGo122Module rec {
+buildGoModule rec {
   pname = "bitmagnet";
-  version = "0.9.5";
+  version = "0.10.0";
 
   src = fetchFromGitHub {
     owner = "bitmagnet-io";
     repo = "bitmagnet";
     rev = "v${version}";
-    hash = "sha256-so9GD9hyGfuqqYq61OD1WJXba22cR4msOPp1wLI5vAU=";
+    hash = "sha256-KgpKpnOVtS3VoIqKhIzDvbdR54M014tQj2/ufhWMZDo=";
   };
 
-  vendorHash = "sha256-aauXgHPZbSiTW9utuHXzJr7GsWs/2aFiGuukA/B9BRc=";
+  vendorHash = "sha256-Scper1eR6I4pCXus/jytSpW8a1omg7sJIPvOn3jYcLM=";
+
+  subPackages = [ "." ];
 
   ldflags = [
     "-s"
-    "-w"
     "-X github.com/bitmagnet-io/bitmagnet/internal/version.GitTag=v${version}"
   ];
 

pkgs/by-name/de/devdash/package.nix

@@ -1,6 +1,6 @@
 {
   lib,
-  buildGo122Module,
+  buildGoModule,
   fetchFromGitHub,
   fetchYarnDeps,
   fixup-yarn-lock,
@@ -14,9 +14,7 @@
   yarn,
 }:
 
-# Breaks with Go 1.23: https://github.com/grafana/agent/issues/6972
-# FIXME: unpin when fixed upstream
-buildGo122Module rec {
+buildGoModule rec {
   pname = "grafana-agent";
   version = "0.44.2";
 
@@ -130,5 +128,9 @@ buildGo122Module rec {
       emilylange
     ];
     mainProgram = "grafana-agent";
+    # Breaks with Go 1.23: https://github.com/grafana/agent/issues/6972
+    # Binary panics at runtime with:
+    # 'panic: pattern "GET /debug/pprof/" (registered at net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap"'
+    broken = true;
   };
 }

pkgs/by-name/gr/grafana-agent/package.nix

@@ -1,29 +1,29 @@
 {
   lib,
-  buildGo122Module,
+  buildGoModule,
   fetchFromGitHub,
   installShellFiles,
+  stdenv,
 }:
 
-buildGo122Module rec {
+buildGoModule rec {
   pname = "hof";
-  version = "0.6.9";
+  version = "0.6.10";
 
   src = fetchFromGitHub {
     owner = "hofstadter-io";
     repo = "hof";
     rev = "v${version}";
-    hash = "sha256-okY+CkPnlndy5H4M1+T1CY21+63+KPBinHoa5+8kQ2M=";
+    hash = "sha256-okc11mXqB/PaXd0vsRuIIL70qWSFprvsZJtE6PvCaIg=";
   };
 
   nativeBuildInputs = [ installShellFiles ];
 
-  vendorHash = "sha256-SmUEVWIyV6k5Lu5zeKGqpij3zUNRZQmIgtf8/Hf7UUs=";
+  vendorHash = "sha256-mLOWnHzKw/B+jFNuswejEnYbPxFkk95I/BWeHRTH55I=";
 
-  subPackages = [ "./cmd/hof/main.go" ];
+  subPackages = [ "./cmd/hof" ];
 
   postInstall = ''
-    mv $out/bin/main $out/bin/hof
     local INSTALL="$out/bin/hof"
     installShellCompletion --cmd hof \
       --bash <($out/bin/hof completion bash) \
@@ -37,5 +37,8 @@ buildGo122Module rec {
     license = licenses.asl20;
     maintainers = with maintainers; [ jfvillablanca ];
     mainProgram = "hof";
+    # Broken on darwin for Go toolchain > 1.22, with error:
+    # 'panic: open /etc/protocols: operation not permitted'
+    broken = stdenv.hostPlatform.isDarwin;
   };
 }

pkgs/by-name/ho/hof/package.nix

@@ -1,11 +1,12 @@
 {
   lib,
-  buildGo122Module,
+  buildGoModule,
   fetchFromGitHub,
+  stdenv,
 }:
-buildGo122Module {
+buildGoModule {
   pname = "honeytrap";
-  version = "unstable-2021-12-20";
+  version = "0-unstable-2021-12-20";
 
   src = fetchFromGitHub {
     owner = "honeytrap";
@@ -26,5 +27,8 @@ buildGo122Module {
     homepage = "https://github.com/honeytrap/honeytrap";
     license = licenses.asl20;
     maintainers = [ ];
+    # Broken on darwin for Go toolchain > 1.22, with error:
+    # 'link: golang.org/x/net/internal/socket: invalid reference to syscall.recvmsg'
+    broken = stdenv.hostPlatform.isDarwin;
   };
 }