Skip to content

Commit d6da1b9

Browse files
authored
Merge pull request #323485 from OPNA2608/fix/qtsystems-nodisplay-crash
libsForQt5.qtsystems: Fetch patch to fix crash on XOpenDisplay failure
2 parents 7244df6 + af77900 commit d6da1b9

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

nixos/tests/lomiri.nix

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ in {
230230
231231
# morph-browser has a separate VM test, there isn't anything new we could test here
232232
233-
# Keep it running, we're using it to check content-hub communication from LSS
233+
machine.send_key("alt-f4")
234234
235235
# LSS provides DE settings
236236
with subtest("system settings open"):
@@ -282,9 +282,7 @@ in {
282282
# Testing any more would require more applications & setup, the fact that it's already being attempted is a good sign
283283
machine.send_key("esc")
284284
285-
machine.send_key("alt-f4") # LSS
286-
machine.sleep(2) # focus is slow to switch to second window, closing it *really* helps with OCR afterwards
287-
machine.send_key("alt-f4") # Morph
285+
machine.send_key("alt-f4")
288286
289287
# The ayatana indicators are an important part of the experience, and they hold the only graphical way of exiting the session.
290288
# There's a test app we could use that also displays their contents, but it's abit inconsistent.

pkgs/development/libraries/qt-5/5.15/default.nix

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,12 @@ let
174174
qtscript = [ ./qtscript.patch ];
175175
qtserialport = [ ./qtserialport.patch ];
176176
qtsystems = [
177+
# Fix crash if no X11 display available
178+
(fetchpatch {
179+
url = "https://salsa.debian.org/qt-kde-team/qt/qtsystems/-/raw/1a4df40671d6f1bb0657a9dfdae4cd9bd48fcf21/debian/patches/1005_check_XOpenDisplay.patch";
180+
hash = "sha256-/onla2nlUSySEgz2IYOYajx/LZkJzAKDyxwAZzy0Ivs=";
181+
})
182+
177183
# Enable building with udisks support
178184
(fetchpatch {
179185
url = "https://salsa.debian.org/qt-kde-team/qt/qtsystems/-/raw/a23fd92222c33479d7f3b59e48116def6b46894c/debian/patches/2001_build_with_udisk.patch";

0 commit comments

Comments
 (0)