Merge pull request #332226 from dotlambda/nextcloud

fetchNextcloudApp: use fetchurl by default

Author: Ma27

nixos/doc/manual/release-notes/rl-2411.section.md

@@ -179,6 +179,10 @@
   and `nodePackages.vscode-json-languageserver-bin` were dropped due to an unmaintained upstream.
   The `vscode-langservers-extracted` package is a maintained drop-in replacement.
 
+- `fetchNextcloudApp` has been rewritten to use `fetchurl` rather than
+  `fetchzip`. This invalidates all existing hashes but you can restore the old
+  behavior by passing it `unpack = true`.
+
 - `haskell.lib.compose.justStaticExecutables` now disallows references to GHC in the
   output by default, to alert users to closure size issues caused by
   [#164630](https://github.com/NixOS/nixpkgs/issues/164630). See ["Packaging

pkgs/build-support/fetchnextcloudapp/default.nix

@@ -8,7 +8,7 @@
 , patches ? [ ]
 , description ? null
 , homepage ? null
-, unpack ? true # whether to use fetchzip rather than fetchurl
+, unpack ? false # whether to use fetchzip rather than fetchurl
 }:
 applyPatches ({
   inherit patches;

pkgs/servers/nextcloud/packages/default.nix

@@ -19,7 +19,6 @@ let packages = self:
         appName = pname;
         appVersion = data.version;
         license = appBaseDefs.${pname};
-        unpack = false;
         inherit (data) url hash description homepage;
       }) {};