triton-llvm: minor refactoring

Author: GaetanLepage

pkgs/by-name/tr/triton-llvm/package.nix

@@ -189,20 +189,21 @@ stdenv.mkDerivation (finalAttrs: {
     );
 
   postPatch =
+    # `CMake Error: cannot write to file "/build/source/llvm/build/lib/cmake/mlir/MLIRTargets.cmake": Permission denied`
     ''
-      # `CMake Error: cannot write to file "/build/source/llvm/build/lib/cmake/mlir/MLIRTargets.cmake": Permission denied`
       chmod +w -R ./mlir
       patchShebangs ./mlir/test/mlir-reduce
-
-      # FileSystem permissions tests fail with various special bits
+    ''
+    # FileSystem permissions tests fail with various special bits
+    + ''
       rm llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test
       rm llvm/unittests/Support/Path.cpp
 
       substituteInPlace llvm/unittests/Support/CMakeLists.txt \
-        --replace "Path.cpp" ""
+        --replace-fail "Path.cpp" ""
     ''
+    # Not sure why this fails
     + lib.optionalString stdenv.hostPlatform.isAarch64 ''
-      # Not sure why this fails
       rm llvm/test/tools/llvm-exegesis/AArch64/latency-by-opcode-name.s
     '';
 
@@ -221,14 +222,15 @@ stdenv.mkDerivation (finalAttrs: {
   checkTarget = "check-all";
   requiredSystemFeatures = [ "big-parallel" ];
 
-  meta = with lib; {
+  meta = {
     description = "Collection of modular and reusable compiler and toolchain technologies";
     homepage = "https://github.com/llvm/llvm-project";
-    license = with licenses; [ ncsa ];
-    maintainers = with maintainers; [
+    changelog = "https://github.com/llvm/llvm-project/releases/tag/llvmorg-${finalAttrs.version}";
+    license = with lib.licenses; [ ncsa ];
+    maintainers = with lib.maintainers; [
       SomeoneSerge
       Madouura
     ];
-    platforms = with platforms; aarch64 ++ x86;
+    platforms = with lib.platforms; aarch64 ++ x86;
   };
 })