Skip to content

Commit ec3c0f5

Browse files
committed
CONTRIBUTING.md: wording nits
I prefer to avoid the phrase "simply" whenever possible
1 parent dcc3d17 commit ec3c0f5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -714,7 +714,7 @@ Don't worry about it.
714714
If there is a build failure however and it happened due to a package related to your change, you need to investigate it of course.
715715
If ofBorg reveals the build to be broken on some platform and you don't have access to that platform, you should set your package's `meta.broken` accordingly.
716716

717-
When in any doubt, please simply ask via a comment in your PR or through one of the help channels.
717+
When in any doubt, please ask via a comment in your PR or through one of the help channels.
718718

719719
## I received a review on my PR, how do I get it over the finish line?
720720

@@ -753,7 +753,7 @@ It is convention to mark review comments that are not critical to the PR as nitp
753753
As the PR author, you should still take a look at these as they will often reveal best practices and unwritten rules that usually have good reasons behind them and you may want to incorporate them into your modus operandi.
754754

755755
Please keep in mind that reviewers almost always mean well here.
756-
Their intent is not to denounce your code, they simply want your code to be as good as it can be.
756+
Their intent is not to denounce your code, they want your code to be as good as it can be.
757757
Through their experience, they may also take notice of a seemingly insignificant issues that have caused significant burden before.
758758

759759
Sometimes however, they can also get a bit carried away and become too perfectionistic.
@@ -779,8 +779,8 @@ If someone left an approving review on your PR and didn't merge a few days later
779779

780780
Please see it as your responsibility to actively remind reviewers of your open PRs.
781781

782-
The easiest way to do so is to simply cause them a Github notification.
783-
Github notifies people involved in the PR when you add a comment to your PR, push your PR or re-request their review.
782+
The easiest way to do so is to cause them a Github notification.
783+
Github notifies people involved in the PR whenever you add a comment to your PR, push your PR or re-request their review.
784784
Doing any of that will get you people's attention again.
785785
Everyone deserves proper attention, and yes that includes you!
786786
However please be mindful that committers can sadly not always give everyone the attention they deserve.

0 commit comments

Comments
 (0)