workflows/labels: count approving reviewers, not reviews (#416668)

Author: wolfgangwalther

.github/workflows/labels.yml

@@ -96,23 +96,24 @@ jobs:
                     name == '12.approved-by: package-maintainer'
                   )
 
-                const approvals =
+                const approvals = new Set(
                   (await github.paginate(github.rest.pulls.listReviews, {
                     owner: context.repo.owner,
                     repo: context.repo.repo,
                     pull_number: pull_request.number
                   }))
                   .filter(review => review.state == 'APPROVED')
                   .map(review => review.user.id)
+                )
 
-                const maintainers = Object.keys(
+                const maintainers = new Set(Object.keys(
                   JSON.parse(await readFile('comparison/maintainers.json', 'utf-8'))
-                )
+                ))
 
                 // And the labels that should be there
                 const after = JSON.parse(await readFile('comparison/changed-paths.json', 'utf-8')).labels
-                if (approvals.length > 0) after.push(`12.approvals: ${approvals.length > 2 ? '3+' : approvals.length}`)
-                if (maintainers.some(id => approvals.includes(id))) after.push('12.approved-by: package-maintainer')
+                if (approvals.size > 0) after.push(`12.approvals: ${approvals.size > 2 ? '3+' : approvals.size}`)
+                if (Array.from(maintainers).some(approvals.has)) after.push('12.approved-by: package-maintainer')
 
                 // Remove the ones not needed anymore
                 await Promise.all(