Skip to content

Commit fdce462

Browse files
author
Isidor Zeuner
committed
alice-vision: default to 3.1.0, enable alignment and full optimization when possible
1 parent c47846f commit fdce462

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

pkgs/development/libraries/alice-vision/3.1.0.nix

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,6 @@ stdenv.mkDerivation rec {
120120
--replace \
121121
'alicevision_add_test(matching_test.cpp NAME "matching" LINKS aliceVision_matching)' \
122122
'alicevision_add_test(matching_test.cpp NAME "matching" LINKS aliceVision_matching lz4)'
123-
'' + lib.optionalString (stdenv.hostPlatform.system == "x86_64-linux") ''
124-
# -O3 currently causes segmentation faults on x86_64-linux
125-
sed -i 's/-O3/-O2/' src/CMakeLists.txt
126123
'';
127124

128125
# Disable warning causing compile error on certain Clang versions
@@ -154,8 +151,9 @@ stdenv.mkDerivation rec {
154151
ALICEVISION_BUILD_DOC = false;
155152
ALICEVISION_BUILD_EXAMPLES = false;
156153
ALICEVISION_BUILD_SOFTWARE = true;
157-
# enabled alignment led to wrong initialization of Vec2 variables
158-
AV_EIGEN_MEMORY_ALIGNMENT = false;
154+
# CCTag package does not support alignment yet, and this must be
155+
# consistent between both packages
156+
AV_EIGEN_MEMORY_ALIGNMENT = ! enableCctag;
159157

160158
ALICEVISION_BUILD_TESTS = doCheck;
161159

pkgs/top-level/all-packages.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20698,7 +20698,7 @@ with pkgs;
2069820698

2069920699
alass = callPackage ../applications/video/alass { };
2070020700

20701-
alice-vision = alice-vision_3_0_0;
20701+
alice-vision = alice-vision_3_1_0;
2070220702

2070320703
alice-vision_3_0_0 = callPackage ../development/libraries/alice-vision/3.0.0.nix {
2070420704
inherit (llvmPackages) openmp;

0 commit comments

Comments
 (0)