Skip to content

Commit ffd38a7

Browse files
committed
xen: resolve some TODO comments
- Migrates to the new platform declaration style. - Removes the separate output TODO, as it is an impossible task. - Removes some superfluous comments. Signed-off-by: Fernando Rodrigues <[email protected]>
1 parent e3b83d4 commit ffd38a7

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

pkgs/build-support/xen/default.nix

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
let
7676
# Inherit helper functions from lib and builtins.
7777
inherit (builtins) elemAt isAttrs;
78+
inherit (lib.systems.inspect.patterns) isLinux isAarch64;
7879
inherit (lib.strings)
7980
concatLines
8081
enableFeature
@@ -83,7 +84,6 @@ let
8384
removeSuffix
8485
versionOlder
8586
;
86-
inherit (lib.platforms) linux aarch64;
8787
inherit (lib) teams;
8888
inherit (lib.licenses)
8989
cc-by-40
@@ -207,8 +207,6 @@ in
207207
stdenv.mkDerivation (finalAttrs: {
208208
inherit pname version;
209209

210-
# TODO: Split $out in $bin for binaries and $lib for libraries.
211-
# TODO: Python package to be in separate output/package.
212210
outputs = [
213211
"out"
214212
"man"
@@ -217,7 +215,6 @@ stdenv.mkDerivation (finalAttrs: {
217215
"boot"
218216
];
219217

220-
# Main Xen source.
221218
src = fetchgit {
222219
url = "https://xenbits.xenproject.org/git-http/xen.git";
223220
inherit rev hash;
@@ -465,8 +462,7 @@ stdenv.mkDerivation (finalAttrs: {
465462

466463
mainProgram = "xl";
467464

468-
#TODO: Migrate meta.platforms to the new lib.systems.inspect.patterns.* format.
469-
platforms = linux;
470-
badPlatforms = aarch64;
465+
platforms = [ isLinux ];
466+
badPlatforms = [ isAarch64 ];
471467
} // meta;
472468
})

0 commit comments

Comments
 (0)