Skip to content

Comments

mnxdom: init at 3.0#492826

Open
doronbehar wants to merge 2 commits intoNixOS:masterfrom
doronbehar:pkg/mnxdom
Open

mnxdom: init at 3.0#492826
doronbehar wants to merge 2 commits intoNixOS:masterfrom
doronbehar:pkg/mnxdom

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 21, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 21, 2026
@bengsparks
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 492826
Commit: 735587ab646bb88bd512f946526e3eba009b5d1b


aarch64-darwin

✅ 4 packages built:
  • mnxdom
  • mnxdom.dev
  • nlohmann_json_schema_validator
  • nlohmann_json_schema_validator.dev

@doronbehar
Copy link
Contributor Author

Thanks for the report. @br337 from some reason ofborg didn't ping you for the nlohmann_json_schema_validator changes and I can't find you in the members of the @NixOS/nixpkgs-maintainers list in order to ask for your review. It might be that you had to approve to join the organization. Please give me your approval on these changes - at least only for nlohmann_json_schema_validator.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants