nixos/zfs: don't prevent a degraded pool machine from booting#497025
Open
SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
Open
nixos/zfs: don't prevent a degraded pool machine from booting#497025SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
Conversation
If eg: a mirror is missing one disk then we still want to boot up.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
|
Should we add a log entry for the degraded state? |
Member
Author
|
Why? It will be in the same state when booted and that can then be observed with zpool status. |
Contributor
|
Right, but it’s one more clue for users that something is wrong. How would users know it’s degraded besides manually running a pool status command? I can’t say I check my pools manually every boot. You’re proposing a change which could increase likelihood of data loss, as users may be unaware of being in a degraded state. I’m only suggesting we log if that’s the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If eg: a mirror is missing one disk then we still want to boot up.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.