Skip to content

Commit 0d3df24

Browse files
authored
Merge pull request #337 from NixOS/ci
Fix build-sanitized-clang.aarch64-linux build
2 parents b7e64b9 + 3165292 commit 0d3df24

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

flake.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flake.nix

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,16 @@
4444
};
4545

4646
coverage =
47-
pkgs.releaseTools.coverageAnalysis {
47+
(pkgs.releaseTools.coverageAnalysis {
4848
name = "patchelf-coverage";
4949
src = self.hydraJobs.tarball;
5050
lcovFilter = ["*/tests/*"];
51-
};
51+
}).overrideAttrs (old: {
52+
preCheck = ''
53+
# coverage cflag breaks this target
54+
NIX_CFLAGS_COMPILE=''${NIX_CFLAGS_COMPILE//--coverage} make -C tests phdr-corruption.so
55+
'';
56+
});
5257

5358
build = forAllSystems (system: nixpkgsFor.${system}.patchelf-new);
5459
build-sanitized = forAllSystems (system: nixpkgsFor.${system}.patchelf-new.overrideAttrs (old: {
@@ -57,8 +62,9 @@
5762
# our cc wrapper arguments
5863
CFLAGS = "-Werror -Wno-unused-command-line-argument";
5964
}));
60-
build-sanitized-clang = forAllSystems (system: self.hydraJobs.build-sanitized.${system}.override {
61-
stdenv = pkgs.libcxxStdenv;
65+
# 32-bit clangStdenv seems broken in nixpkgs
66+
build-sanitized-clang = nixpkgs.lib.genAttrs [ "x86_64-linux" "aarch64-linux" ] (system: self.hydraJobs.build-sanitized.${system}.override {
67+
stdenv = nixpkgsFor.${system}.libcxxStdenv;
6268
});
6369

6470
release = pkgs.releaseTools.aggregate
@@ -70,7 +76,6 @@
7076
self.hydraJobs.build-sanitized.x86_64-linux
7177
self.hydraJobs.build-sanitized.i686-linux
7278
self.hydraJobs.build-sanitized-clang.x86_64-linux
73-
self.hydraJobs.build-sanitized-clang.i686-linux
7479
];
7580
meta.description = "Release-critical builds";
7681
};

0 commit comments

Comments
 (0)