test: add test for --remove-needed-version

Author: chitao1234

.gitignore

@@ -33,6 +33,7 @@ Makefile
 /tests/contiguous-note-sections
 /tests/simple-pie
 /tests/simple-execstack
+/tests/symver
 
 .direnv/
 .vscode/

tests/Makefile.am

@@ -1,6 +1,7 @@
 LIBS =
 
-check_PROGRAMS = simple-pie simple simple-execstack main too-many-strtab main-scoped big-dynstr no-rpath contiguous-note-sections
+check_PROGRAMS = simple-pie simple simple-execstack main too-many-strtab main-scoped big-dynstr no-rpath contiguous-note-sections \
+				 symver
 
 no_rpath_arch_TESTS = \
   no-rpath-amd64.sh \
@@ -51,7 +52,8 @@ src_TESTS = \
   overlapping-segments-after-rounding.sh \
   shared-rpath.sh \
   short-first-segment.sh \
-  empty-note.sh
+  empty-note.sh \
+  remove-needed-version.sh
 
 build_TESTS = \
   $(no_rpath_arch_TESTS)
@@ -123,7 +125,8 @@ check_DATA = libbig-dynstr.debug
 # - with libtool, it is difficult to control options
 # - with libtool, it is not possible to compile convenience *dynamic* libraries :-(
 check_PROGRAMS += libfoo.so libfoo-scoped.so libbar.so libbar-scoped.so libsimple.so libsimple-execstack.so libbuildid.so libtoomanystrtab.so \
-                  phdr-corruption.so many-syms-main libmany-syms.so liboveralign.so libshared-rpath.so
+                  phdr-corruption.so many-syms-main libmany-syms.so liboveralign.so libshared-rpath.so \
+				  libsymver.so libsymver-old.so
 
 libbuildid_so_SOURCES = simple.c
 libbuildid_so_LDFLAGS = $(LDFLAGS_sharedlib) -Wl,--build-id
@@ -180,6 +183,18 @@ phdr_corruption_so_SOURCES = void.c phdr-corruption.ld
 phdr_corruption_so_LDFLAGS = -nostdlib -shared -Wl,-T$(srcdir)/phdr-corruption.ld
 phdr_corruption_so_CFLAGS =
 
+libsymver_so_SOURCES = libsymver.c
+libsymver_so_LDFLAGS = $(LDFLAGS_sharedlib) -Wl,--version-script=libsymver.map
+libsymver_so_CFLAGS = $(AM_CFLAGS)
+libsymver_old_so_SOURCES = libsymver-old.c
+libsymver_old_so_LDFLAGS = $(LDFLAGS_sharedlib) -Wl,--version-script=libsymver-old.map
+libsymver_old_so_CFLAGS = $(AM_CFLAGS)
+symver_SOURCES = symver.c
+symver_LDFLAGS = $(LDFLAGS_local)
+symver_LDADD = -lsymver $(AM_LDADD)
+symver_DEPENDENCIES = libsymver.so libsymver-old.so
+symver_CFLAGS = $(AM_CFLAGS)
+
 many-syms.c:
 	i=1; while [ $$i -le 2000 ]; do echo "void f$$i() {};"; i=$$(($$i + 1)); done > $@
 

tests/libsymver-old.c

@@ -0,0 +1,11 @@
+#include <stdio.h>
+
+__asm__(".symver foo_v1, foo@@V1");
+
+void foo_v1() {
+    printf("foo_v1\n");
+}
+
+void bar() {
+    printf("bar_unver\n");
+}

tests/libsymver-old.map

@@ -0,0 +1,4 @@
+V1 {
+    global: foo;
+    local: foo_v1;
+};

tests/libsymver.c

@@ -0,0 +1,18 @@
+#include <stdio.h>
+
+__asm__(".symver foo_v1, foo@V1");
+__asm__(".symver foo_v2, foo@@V2");
+
+void foo_v1() {
+    printf("foo_v1\n");
+}
+
+void foo_v2() {
+    printf("foo_v2\n");
+}
+
+
+// version defined in version script
+void bar() {
+    printf("bar_ver\n");
+}

tests/libsymver.map

@@ -0,0 +1,11 @@
+V1 {
+    global: foo;
+    local: foo_v1;
+};
+V2 {
+    global: foo;
+    local: foo_v2;
+};
+VER {
+    global: bar;
+};

tests/remove-needed-version.sh

@@ -0,0 +1,50 @@
+#! /bin/sh -e
+SCRATCH="scratch/$(basename "$0" .sh)"
+PATCHELF="$(readlink -f "../src/patchelf")"
+READELF="${READELF:-readelf}"
+MAIN=symver
+LIBNEW=libsymver.so
+LIBOLD=libsymver-old.so
+
+
+rm -rf "$SCRATCH"
+mkdir -p "$SCRATCH"
+
+cp $MAIN $LIBNEW $LIBOLD "${SCRATCH}/"
+
+cd "$SCRATCH"
+
+fail() {
+    echo $1
+    "$READELF" -a -W $MAIN
+    "$READELF" -a -W $LIBNEW
+    "$READELF" -a -W $LIBOLD
+    exit $2
+}
+
+# sanity check
+exit_code=0
+LD_LIBRARY_PATH="$PWD" ./${MAIN} || exit_code=$?
+if [ $exit_code -ne 0 ]; then
+  fail "basic check" $exit_code
+fi
+
+# replace with old version
+mv $LIBOLD $LIBNEW
+
+# should NOT run before patch
+exit_code=0
+LD_LIBRARY_PATH="$PWD" ./${MAIN} || exit_code=$?
+if [ $exit_code -eq 0 ]; then
+  fail "patch check" 1
+fi
+
+${PATCHELF} --remove-needed-version $LIBNEW V2 \
+            --remove-needed-version $LIBNEW VER $MAIN || fail "patchelf" -1 
+
+# should run after removing version
+exit_code=0
+LD_LIBRARY_PATH="$PWD" ./${MAIN} || exit_code=$?
+if [ $exit_code -ne 0 ]; then
+  fail "patch check" $exit_code
+fi

tests/symver.c

@@ -0,0 +1,7 @@
+void foo();
+void bar();
+
+int main() {
+    foo();
+    bar();
+}