From b80e8b3b9368d99f0af591c99b9c24c811c9b6d0 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Tue, 11 Nov 2025 16:48:13 +0100 Subject: [PATCH 1/3] Drop i686-linux build This already failed to evaluate due to pre-commit's dependency on dotnet-sdk, which is unsupported on i686-linux. This makes `nix flake check --all-systems` succeed again. --- flake.nix | 9 --------- 1 file changed, 9 deletions(-) diff --git a/flake.nix b/flake.nix index fb05fc24..249b671d 100644 --- a/flake.nix +++ b/flake.nix @@ -22,7 +22,6 @@ supportedSystems = [ "x86_64-linux" - "i686-linux" "aarch64-linux" ]; forAllSystems = lib.genAttrs supportedSystems; @@ -174,14 +173,12 @@ constituents = [ self.hydraJobs.tarball self.hydraJobs.build.x86_64-linux - self.hydraJobs.build.i686-linux self.hydraJobs.build-cmake.x86_64-linux self.hydraJobs.build-meson.x86_64-linux # FIXME: add aarch64 emulation to our github action... #self.hydraJobs.build.aarch64-linux self.hydraJobs.build-sanitized.x86_64-linux #self.hydraJobs.build-sanitized.aarch64-linux - self.hydraJobs.build-sanitized.i686-linux self.hydraJobs.build-sanitized-clang.x86_64-linux ]; meta.description = "Release-critical builds"; @@ -228,9 +225,6 @@ glibc = mkShell self.packages.${system}.patchelf; default = self.devShells.${system}.glibc; } - // lib.optionalAttrs (system != "i686-linux") { - musl = mkShell self.packages.${system}.patchelf-musl; - } ); packages = forAllSystems ( @@ -287,9 +281,6 @@ patchelf-win32 = patchelfForWindowsStatic pkgs.pkgsCross.mingw32; patchelf-win64 = patchelfForWindowsStatic pkgs.pkgsCross.mingwW64; } - // lib.optionalAttrs (system != "i686-linux") { - patchelf-musl = patchelfFor nixpkgs.legacyPackages.${system}.pkgsMusl; - } ); }; From fa480a0027bb915dd35d973b515c06babd11e6d8 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Tue, 11 Nov 2025 16:52:51 +0100 Subject: [PATCH 2/3] Run 'nix flake check' in CI --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 39eea409..86973192 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,9 @@ jobs: steps: - uses: actions/checkout@v4 - uses: cachix/install-nix-action@v31 - - run: nix-build -A hydraJobs.release + - run: | + nix flake check --extra-experimental-features 'nix-command flakes' --all-systems --no-build + nix-build -A hydraJobs.release ubuntu: runs-on: ubuntu-latest steps: From 92adc411e8619737793a73412f5170247f6d97a7 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Tue, 11 Nov 2025 16:55:48 +0100 Subject: [PATCH 3/3] Don't run every CI job twice on PRs --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 86973192..2ad3663d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,6 +3,8 @@ on: pull_request: merge_group: push: + branches: + - master jobs: shellcheck: runs-on: ubuntu-latest