Pet class holds reference to removed ActiveMob's (Memory leaky)

[Mykindos]

Noticed this when debugging why unloaded worlds were remaining in memory

Tried everything possible to unregister, despawn pets on world unload but was having no luck.
I fixed this by making ActiveMob a weak reference, but you should also be able to fix this by nullifying activeMob when it is removed (this is currently not possible via API, setActiveMob(null) will just call despawn instead.

Paper Version: 1.21.4
Mythic, ModelEngine & MCPets version: latest dev builds

[AlexandreChaussard]

There's probably something at stake here, but your screenshot highlights at most a 89 kB extraweight from MCPets, which appears to be a neglictable overload. I don't think it is responsible for any kind of memory issue. Besides, MCPets holds at most a pointer to an ActiveMob, which is a MythicMobs instance, therefore managed by them directly. I'm not sure I can do anything about it personally =/

[Mykindos]

There's probably something at stake here, but your screenshot highlights at most a 89 kB extraweight from MCPets, which appears to be a neglictable overload. I don't think it is responsible for any kind of memory issue. Besides, MCPets holds at most a pointer to an ActiveMob, which is a MythicMobs instance, therefore managed by them directly. I'm not sure I can do anything about it personally =/

I believe it holding the pointer to the activemob is the problem, even when the activemob no longer exists or the world is unloaded it will keep it in memory. Its a very niche issue so I don't expect you to do anything about it, I ended up fixing it by modifying the source to use WeakReference to ActiveMob instead

[Browsit]

This sounds like it should be a pull request.