Fix linting.

Author: colonelpopcorn

lib/virtualbox.js

@@ -82,16 +82,15 @@ class Virtualbox {
       this._executor,
       this._vBoxManageBinary
     );
+    this.vboxmanage = defaultvboxmanage;
+    this.SCAN_CODES = require('./scan-codes');
   }
 
   static create(logging, executor) {
     const logger = !!logging ? logging : defaultLogger;
     return new Virtualbox(logger, executor);
   }
 
-  vboxmanage = defaultvboxmanage;
-  SCAN_CODES = require('./scan-codes');
-
   pause(vmname, callback) {
     this._logging.info('Pausing VM "%s"', vmname);
     this.vboxmanage(['controlvm', vmname, 'pause'], function (error, _) {
@@ -457,10 +456,10 @@ class Virtualbox {
         options.run,
       image_name = options.image_name || path;
 
-    this.guestproperty.os(vm, function (os_type) {
+    this.guestproperty.os(vm, (os_type) => {
       switch (os_type) {
         case known_OS_types.WINDOWS:
-          exec(
+          this._executor(
             {
               vm: vm,
               user: options.user,
@@ -473,7 +472,7 @@ class Virtualbox {
           break;
         case known_OS_types.MAC:
         case known_OS_types.LINUX:
-          exec(
+          this._executor(
             {
               vm: vm,
               user: options.user,
@@ -527,22 +526,21 @@ class VboxStorage {
     this._logging = logging;
     this._executor = executor;
     this._vBoxManageBinary = vBoxManageBinary;
+    this.vboxmanage = defaultvboxmanage;
   }
 
-  vboxmanage = defaultvboxmanage;
-
   addCtl(options, callback) {
     var vm = options.vm || options.name || options.vmname || options.title,
       device_name = options.perhiperal_name || 'IDE',
       type = options.type || 'ide';
-    logging.info(
+    this._logging.info(
       'Adding "%s" controller named "%s" to %s',
       type,
       device_name,
       vm
     );
     var cmd = ['storagectl', vm, '--name', device_name, '--add', type];
-    vboxmanage(cmd, callback);
+    this.vboxmanage(cmd, callback);
   }
 
   attach(options, callback) {
@@ -552,7 +550,7 @@ class VboxStorage {
       device = options.device || '0',
       type = options.type || 'dvddrive',
       medium = options.medium;
-    logging.info(
+    this._logging.info(
       'Mounting "%s" to controller named "%s" on %s',
       medium,
       device_name,
@@ -572,7 +570,7 @@ class VboxStorage {
       '--medium',
       medium,
     ];
-    vboxmanage(cmd, callback);
+    this.vboxmanage(cmd, callback);
   }
 }
 
@@ -582,10 +580,9 @@ class VboxGuestProperty {
     this._executor = executor;
     this._vBoxManageBinary = vBoxManageBinary;
     this.os_type = null;
+    this.vboxmanage = defaultvboxmanage;
   }
 
-  vboxmanage = defaultvboxmanage;
-
   get(options, callback) {
     var vm = options.vm || options.name || options.vmname || options.title,
       key = options.key,
@@ -703,10 +700,9 @@ class VboxExtraData {
     this._logging = logging;
     this._executor = executor;
     this._vBoxManageBinary = vBoxManageBinary;
+    this.vboxmanage = defaultvboxmanage;
   }
 
-  vboxmanage = defaultvboxmanage;
-
   get(options, callback) {
     var vm = options.vm || options.name || options.vmname || options.title,
       key = options.key,

package-lock.json

@@ -71,7 +71,7 @@
   "devDependencies": {
     "async": "^2.1.4",
     "jest": "^26.0.1",
-    "jshint": "^2.10.2"
+    "jshint": "^2.12.0"
   },
   "engines": {
     "engine": "node >= 0.4.1"

package.json

@@ -3,7 +3,7 @@
 var virtualbox = require('../../lib/virtualbox'),
   vmName = 'node-virtualbox-test-machine';
 
-virtualbox.export(args[0], args[1], function (error) {
+virtualbox.export(vmName, 'test-export', function (error) {
   if (error) {
     throw error;
   }

test/integration/export.js

@@ -1,20 +1,18 @@
 'use strict';
 
 var virtualbox = require('../../lib/virtualbox'),
-  vmName = 'node-virtualbox-test-machine';
+  vmname = 'node-virtualbox-test-machine',
+  key = 'some-data-key';
 
-virtualbox.extradata.get({ vm: args[0], key: args[1] }, function (
-  error,
-  value
-) {
+virtualbox.extradata.get({ vmname, key }, function (error, value) {
   if (error) {
     throw error;
   }
 
   console.log(
     'Virtual Machine "%s" extra "%s" value is "%s"',
-    args[0],
-    args[1],
+    vmname,
+    key,
     value
   );
 });