Skip to content

Commit 298d074

Browse files
author
Ruben Bridgewater
committed
Replace jshint with standard
1 parent 742226e commit 298d074

File tree

13 files changed

+1015
-1049
lines changed

13 files changed

+1015
-1049
lines changed

‎.jshintignore

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎.jshintrc

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
[![Build Status](https://travis-ci.org/NodeRedis/node-redis-parser.png?branch=master)](https://travis-ci.org/NodeRedis/node-redis-parser)
22
[![Code Climate](https://codeclimate.com/github/NodeRedis/node-redis-parser/badges/gpa.svg)](https://codeclimate.com/github/NodeRedis/node-redis-parser)
33
[![Test Coverage](https://codeclimate.com/github/NodeRedis/node-redis-parser/badges/coverage.svg)](https://codeclimate.com/github/NodeRedis/node-redis-parser/coverage)
4+
[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg)](http://standardjs.com/)
45

56
# redis-parser
67

‎benchmark/index.js

Lines changed: 116 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -1,191 +1,189 @@
1-
var Benchmark = require('benchmark');
2-
var suite = new Benchmark.Suite();
1+
var Benchmark = require('benchmark')
2+
var suite = new Benchmark.Suite()
33

4-
var Parser = require('./../');
5-
var ParserOLD = require('./old/parser');
4+
var Parser = require('./../')
5+
var ParserOLD = require('./old/parser')
66

77
function returnError (error) {
8-
error = null;
8+
error = null
99
}
1010

1111
function checkReply () {}
1212

1313
function shuffle (array) {
14-
var currentIndex = array.length;
15-
var temporaryValue;
16-
var randomIndex;
17-
18-
// While there remain elements to shuffle...
19-
while (currentIndex !== 0) {
20-
// Pick a remaining element...
21-
randomIndex = Math.floor(Math.random() * currentIndex);
22-
currentIndex -= 1;
23-
24-
// And swap it with the current element.
25-
temporaryValue = array[currentIndex];
26-
array[currentIndex] = array[randomIndex];
27-
array[randomIndex] = temporaryValue;
28-
}
29-
30-
return array;
14+
var currentIndex = array.length
15+
var temporaryValue
16+
var randomIndex
17+
18+
// While there remain elements to shuffle...
19+
while (currentIndex !== 0) {
20+
// Pick a remaining element...
21+
randomIndex = Math.floor(Math.random() * currentIndex)
22+
currentIndex -= 1
23+
24+
// And swap it with the current element.
25+
temporaryValue = array[currentIndex]
26+
array[currentIndex] = array[randomIndex]
27+
array[randomIndex] = temporaryValue
28+
}
29+
30+
return array
3131
}
3232

33-
var startBuffer = new Buffer('$100\r\nabcdefghij');
34-
var chunkBuffer = new Buffer('abcdefghijabcdefghijabcdefghij');
35-
var stringBuffer = new Buffer('+testing a simple string\r\n');
36-
var integerBuffer = new Buffer(':1237884\r\n');
37-
var errorBuffer = new Buffer('-Error ohnoesitbroke\r\n');
38-
var arrayBuffer = new Buffer('*1\r\n*1\r\n$1\r\na\r\n');
39-
var endBuffer = new Buffer('\r\n');
33+
var startBuffer = new Buffer('$100\r\nabcdefghij')
34+
var chunkBuffer = new Buffer('abcdefghijabcdefghijabcdefghij')
35+
var stringBuffer = new Buffer('+testing a simple string\r\n')
36+
var integerBuffer = new Buffer(':1237884\r\n')
37+
var errorBuffer = new Buffer('-Error ohnoesitbroke\r\n')
38+
var arrayBuffer = new Buffer('*1\r\n*1\r\n$1\r\na\r\n')
39+
var endBuffer = new Buffer('\r\n')
4040
var lorem = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, ' +
41-
'sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. ' +
42-
'Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ' +
43-
'ut aliquip ex ea commodo consequat. Duis aute irure dolor in'; // 256 chars
44-
var bigStringArray = (new Array(Math.pow(2, 16) / lorem.length).join(lorem + ' ')).split(' '); // Math.pow(2, 16) chars long
45-
var startBigBuffer = new Buffer('$' + (4 * 1024 * 1024) + '\r\n' + lorem);
46-
var chunks = new Array(64);
41+
'sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. ' +
42+
'Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ' +
43+
'ut aliquip ex ea commodo consequat. Duis aute irure dolor in' // 256 chars
44+
var bigStringArray = (new Array(Math.pow(2, 16) / lorem.length).join(lorem + ' ')).split(' ') // Math.pow(2, 16) chars long
45+
var startBigBuffer = new Buffer('$' + (4 * 1024 * 1024) + '\r\n' + lorem)
46+
var chunks = new Array(64)
4747
for (var i = 0; i < 64; i++) {
48-
chunks[i] = new Buffer(shuffle(bigStringArray).join(' ') + '.'); // Math.pow(2, 16) chars long
48+
chunks[i] = new Buffer(shuffle(bigStringArray).join(' ') + '.') // Math.pow(2, 16) chars long
4949
}
5050

5151
var parserOld = new ParserOLD({
52-
returnReply: checkReply,
53-
returnError: returnError,
54-
returnFatalError: returnError,
55-
name: 'javascript'
56-
});
52+
returnReply: checkReply,
53+
returnError: returnError,
54+
returnFatalError: returnError,
55+
name: 'javascript'
56+
})
5757

5858
var parserHiRedis = new Parser({
59-
returnReply: checkReply,
60-
returnError: returnError,
61-
returnFatalError: returnError,
62-
name: 'hiredis'
63-
});
59+
returnReply: checkReply,
60+
returnError: returnError,
61+
returnFatalError: returnError,
62+
name: 'hiredis'
63+
})
6464

6565
var parser = new Parser({
66-
returnReply: checkReply,
67-
returnError: returnError,
68-
returnFatalError: returnError,
69-
name: 'javascript'
70-
});
66+
returnReply: checkReply,
67+
returnError: returnError,
68+
returnFatalError: returnError,
69+
name: 'javascript'
70+
})
7171

7272
// BULK STRINGS
7373

7474
suite.add('OLD CODE: multiple chunks in a bulk string', function () {
75-
parserOld.execute(startBuffer);
76-
parserOld.execute(chunkBuffer);
77-
parserOld.execute(chunkBuffer);
78-
parserOld.execute(chunkBuffer);
79-
parserOld.execute(endBuffer);
80-
});
75+
parserOld.execute(startBuffer)
76+
parserOld.execute(chunkBuffer)
77+
parserOld.execute(chunkBuffer)
78+
parserOld.execute(chunkBuffer)
79+
parserOld.execute(endBuffer)
80+
})
8181

8282
suite.add('HIREDIS: multiple chunks in a bulk string', function () {
83-
parserHiRedis.execute(startBuffer);
84-
parserHiRedis.execute(chunkBuffer);
85-
parserHiRedis.execute(chunkBuffer);
86-
parserHiRedis.execute(chunkBuffer);
87-
parserHiRedis.execute(endBuffer);
88-
});
83+
parserHiRedis.execute(startBuffer)
84+
parserHiRedis.execute(chunkBuffer)
85+
parserHiRedis.execute(chunkBuffer)
86+
parserHiRedis.execute(chunkBuffer)
87+
parserHiRedis.execute(endBuffer)
88+
})
8989

9090
suite.add('NEW CODE: multiple chunks in a bulk string', function () {
91-
parser.execute(startBuffer);
92-
parser.execute(chunkBuffer);
93-
parser.execute(chunkBuffer);
94-
parser.execute(chunkBuffer);
95-
parser.execute(endBuffer);
96-
});
91+
parser.execute(startBuffer)
92+
parser.execute(chunkBuffer)
93+
parser.execute(chunkBuffer)
94+
parser.execute(chunkBuffer)
95+
parser.execute(endBuffer)
96+
})
9797

9898
// BIG BULK STRING
9999

100100
suite.add('\nOLD CODE: 4mb bulk string', function () {
101-
parserOld.execute(startBigBuffer);
102-
for (var i = 0; i < 64; i++) {
103-
parserOld.execute(chunks[i]);
104-
}
105-
parserOld.execute(endBuffer);
106-
});
101+
parserOld.execute(startBigBuffer)
102+
for (var i = 0; i < 64; i++) {
103+
parserOld.execute(chunks[i])
104+
}
105+
parserOld.execute(endBuffer)
106+
})
107107

108108
suite.add('HIREDIS: 4mb bulk string', function () {
109-
parserHiRedis.execute(startBigBuffer);
110-
for (var i = 0; i < 64; i++) {
111-
parserHiRedis.execute(chunks[i]);
112-
}
113-
parserHiRedis.execute(endBuffer);
114-
});
109+
parserHiRedis.execute(startBigBuffer)
110+
for (var i = 0; i < 64; i++) {
111+
parserHiRedis.execute(chunks[i])
112+
}
113+
parserHiRedis.execute(endBuffer)
114+
})
115115

116116
suite.add('NEW CODE: 4mb bulk string', function () {
117-
parser.execute(startBigBuffer);
118-
for (var i = 0; i < 64; i++) {
119-
parser.execute(chunks[i]);
120-
}
121-
parser.execute(endBuffer);
122-
});
117+
parser.execute(startBigBuffer)
118+
for (var i = 0; i < 64; i++) {
119+
parser.execute(chunks[i])
120+
}
121+
parser.execute(endBuffer)
122+
})
123123

124124
// STRINGS
125125

126126
suite.add('\nOLD CODE: + simple string', function () {
127-
parserOld.execute(stringBuffer);
128-
});
127+
parserOld.execute(stringBuffer)
128+
})
129129

130130
suite.add('HIREDIS: + simple string', function () {
131-
parserHiRedis.execute(stringBuffer);
132-
});
131+
parserHiRedis.execute(stringBuffer)
132+
})
133133

134134
suite.add('NEW CODE: + simple string', function () {
135-
parser.execute(stringBuffer);
136-
});
135+
parser.execute(stringBuffer)
136+
})
137137

138138
// INTEGERS
139139

140140
suite.add('\nOLD CODE: + integer', function () {
141-
parserOld.execute(integerBuffer);
142-
});
141+
parserOld.execute(integerBuffer)
142+
})
143143

144144
suite.add('HIREDIS: + integer', function () {
145-
parserHiRedis.execute(integerBuffer);
146-
});
145+
parserHiRedis.execute(integerBuffer)
146+
})
147147

148148
suite.add('NEW CODE: + integer', function () {
149-
parser.execute(integerBuffer);
150-
});
149+
parser.execute(integerBuffer)
150+
})
151151

152152
// ARRAYS
153153

154154
suite.add('\nOLD CODE: * array', function () {
155-
parserOld.execute(arrayBuffer);
156-
});
155+
parserOld.execute(arrayBuffer)
156+
})
157157

158158
suite.add('HIREDIS: * array', function () {
159-
parserHiRedis.execute(arrayBuffer);
160-
});
159+
parserHiRedis.execute(arrayBuffer)
160+
})
161161

162162
suite.add('NEW CODE: * array', function () {
163-
parser.execute(arrayBuffer);
164-
});
165-
163+
parser.execute(arrayBuffer)
164+
})
166165

167166
// ERRORS
168167

169168
suite.add('\nOLD CODE: * error', function () {
170-
parserOld.execute(errorBuffer);
171-
});
169+
parserOld.execute(errorBuffer)
170+
})
172171

173172
suite.add('HIREDIS: * error', function () {
174-
parserHiRedis.execute(errorBuffer);
175-
});
173+
parserHiRedis.execute(errorBuffer)
174+
})
176175

177176
suite.add('NEW CODE: * error', function () {
178-
parser.execute(errorBuffer);
179-
});
180-
177+
parser.execute(errorBuffer)
178+
})
181179

182180
// add listeners
183181
suite.on('cycle', function (event) {
184-
console.log(String(event.target));
185-
});
182+
console.log(String(event.target))
183+
})
186184

187185
suite.on('complete', function () {
188-
console.log('\n\nFastest is ' + this.filter('fastest').map('name'));
189-
});
186+
console.log('\n\nFastest is ' + this.filter('fastest').map('name'))
187+
})
190188

191-
suite.run({ delay: 1, minSamples: 150 });
189+
suite.run({ delay: 1, minSamples: 150 })

0 commit comments

Comments
 (0)