Checkbox "Plugin enabled"; Combo with global theme is restoring value

Author: paulvi

README.md

@@ -37,7 +37,9 @@ If there are updates here, they will be released together with [Nodeclipse train
 0.50
 0.55
 0.60
-0.65 (2014-08) change icon; combo to apply one of bundled themes to all categories
+0.65 (2014-08) change icon; 
+	Checkbox "Plugin enabled";
+	combo to apply one of bundled themes to all categories	
 	(this is done for case when switching to black themes and back)
 
 ## Themes
@@ -109,9 +111,12 @@ pm.eclipse.editbox.provider.java_enabled=true
 pm.eclipse.editbox.provider.java_fileNames=*.java,*.class,*.gradle,*.groovy,*.scala
 ```
 
-Catalog is list of Themes.  
-Provider `BoxProviderImpl` is Category . Provider is holding theme (Settings object). 
-Theme `BoxSettingsImpl` is set of colors .  
+
+Theme `BoxSettingsImpl` is set of colors .
+Provider is theme applied to some category. Provider is holding current theme (Settings object).
+Provider `BoxProviderImpl` is associated with category String (aka Provider name).  
+Catalog is list of Themes, that provider has.  
+
 
 ### Build
 

pm.eclipse.editbox/src/pm/eclipse/editbox/EditBox.java

@@ -2,17 +2,25 @@
 
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
+import org.eclipse.jface.action.ActionContributionItem;
+import org.eclipse.jface.action.CoolBarManager;
+import org.eclipse.jface.action.IContributionItem;
+import org.eclipse.jface.action.IToolBarManager;
+import org.eclipse.jface.action.ToolBarContributionItem;
 import org.eclipse.jface.resource.ImageDescriptor;
+import org.eclipse.jface.window.ApplicationWindow;
+import org.eclipse.ui.IWorkbenchWindow;
+import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.plugin.AbstractUIPlugin;
 import org.osgi.framework.BundleContext;
 
 import pm.eclipse.editbox.impl.BoxProviderRegistry;
 
 public class EditBox extends AbstractUIPlugin {
 
-	private static final String ENABLED = "ENABLED";
-
 	public static final String PLUGIN_ID = "pm.eclipse.editbox";
+	public static final String PREF_ENABLED = "enabled";
+	public static final String PREF_DEFAULT_THEME = "default_theme";
 
 	private static EditBox plugin;
 
@@ -43,15 +51,49 @@ public BoxProviderRegistry getProviderRegistry(){
 		return registry == null ? (registry = new BoxProviderRegistry()) : registry;
 	}
 
+	/** check if enabled from PreferenceStore */
 	public boolean isEnabled() {
 		//if (getPreferenceStore().contains(ENABLED))
-			return getPreferenceStore().getBoolean(ENABLED);
+			return getPreferenceStore().getBoolean(PREF_ENABLED);
 		//return false;
 	}
 
 	public void setEnabled(boolean flag){
-		getPreferenceStore().setValue(ENABLED, flag);
+		getPreferenceStore().setValue(PREF_ENABLED, flag);
+	}
+	
+	//+ {
+	//TODO move to utils class?
+	/** called from EditboxPreferencePage 
+	 * TODO still can't toggle on main window from Preferences
+	 * */
+	public static void toggleToolBarItemInAllWindows(boolean enabled) {
+		IWorkbenchWindow[] windows = PlatformUI.getWorkbench().getWorkbenchWindows();
+		for (IWorkbenchWindow window: windows){
+			toggleToolBarItem(window, enabled);			
+		}
 	}
+	/** called from EditBoxStartup */
+	public static void toggleToolBarItem(IWorkbenchWindow window, boolean enabled) {
+		// any better way to toggle toolbar button in 3.2?
+		if (window instanceof ApplicationWindow) {
+			CoolBarManager coolBarManager = ((ApplicationWindow) window).getCoolBarManager();
+			if (coolBarManager != null) {
+				IContributionItem item = coolBarManager.find("pm.eclipse.editbox.ActionSetId");
+				if (item instanceof ToolBarContributionItem) {
+					IToolBarManager tbMgr2 = ((ToolBarContributionItem) item).getToolBarManager();
+					if (tbMgr2 != null) {
+						IContributionItem item2 = tbMgr2.find("pm.eclipse.editbox.EnableEditboxActionId");
+						if (item2 instanceof ActionContributionItem) {
+							((ActionContributionItem) item2).getAction().setChecked(enabled);
+						}
+					}
+				}
+			}
+		}
+	}
+	//}
+	
 
 	public static void logError(Object source, String msg, Throwable error) {
 		String src = "";

pm.eclipse.editbox/src/pm/eclipse/editbox/actions/EditBoxStartup.java

@@ -19,6 +19,7 @@
 
 public class EditBoxStartup implements IStartup {
 
+	@Override
 	public void earlyStartup() {
 		if (!EditBox.getDefault().isEnabled())
 			return;
@@ -37,7 +38,8 @@ public void run() {
 					if (handlerService != null)
 						try {
 							handlerService.executeCommand(new ParameterizedCommand(command, null), null);
-							toggle(window);
+							EditBox.toggleToolBarItem(window, true);
+							//EditBox.toggleToolBarItemInAllWindows(enabled); //no need as there is to be only one window
 						} catch (Exception e) {
 							EditBox.logError(this, "Failed to enable EditBox at startup", e);
 						}
@@ -47,23 +49,4 @@ public void run() {
 		});
 	}
 
-	protected void toggle(IWorkbenchWindow window) {
-		// any better way to toggle toolbar button in 3.2?
-		if (window instanceof ApplicationWindow) {
-			CoolBarManager coolBarManager = ((ApplicationWindow) window).getCoolBarManager();
-			if (coolBarManager != null) {
-				IContributionItem item = coolBarManager.find("pm.eclipse.editbox.ActionSetId");
-				if (item instanceof ToolBarContributionItem) {
-					IToolBarManager tbMgr2 = ((ToolBarContributionItem) item).getToolBarManager();
-					if (tbMgr2 != null) {
-						IContributionItem item2 = tbMgr2.find("pm.eclipse.editbox.EnableEditboxActionId");
-						if (item2 instanceof ActionContributionItem) {
-							((ActionContributionItem) item2).getAction().setChecked(true);
-						}
-					}
-				}
-			}
-		}
-	}
-
 }

pm.eclipse.editbox/src/pm/eclipse/editbox/actions/EnableEditBox.java

@@ -18,6 +18,7 @@
 import pm.eclipse.editbox.impl.BoxProviderRegistry;
 
 //keep it stateless since called from commands
+/** this is actually state toggler as both execute() and run() apply opposite state */
 public class EnableEditBox extends AbstractHandler implements IWorkbenchWindowActionDelegate {
 
 	public static final String COMMAND_ID = "pm.eclipse.editbox.actions.EnableEditBoxCmd";

pm.eclipse.editbox/src/pm/eclipse/editbox/impl/BoxProviderRegistry.java

@@ -28,11 +28,24 @@ public class BoxProviderRegistry {
 	private static final String PROVIDERS = "proivders";  
 	// always added. Is it useless?
 	private static final String PROVIDER_ID_ = "pm.eclipse.editbox.provider.";
-	//+
+	//+ {
 	public static final String[] ALL_THEMES_ARRAY = {"Default", "Whitebox", "OnClick", "GreyGradient", "Java_v_20",
 		"RainbowDrops", "RainbowDropsLine", "RainbowDropsLineFill", 
 		"BlueToDeepBlue", "OrangeToRed", "BlueGradient22WithDarkBoldLeftBorder", "BlueLight", "PaleBlue"}; 
 	private static final List<String> ALL_THEMES_LIST = Arrays.asList(ALL_THEMES_ARRAY);
+	public static final String DEFAULT_THEME = "PaleBlue";
+	
+	/** return index within ALL_THEMES_ARRAY or -1 if not found */
+	public static int getThemeIndex(String preferedThemeName) {
+		for (int i = 0; i<ALL_THEMES_ARRAY.length; i++){
+			if (ALL_THEMES_ARRAY[i].equalsIgnoreCase(preferedThemeName)){
+				return i;
+			}
+		}
+		return -1; 
+	}
+	//}
+	
 
 	protected Collection<IBoxProvider> providers;
 	protected Map<IWorkbenchPart, IBoxDecorator> decorators;
@@ -99,7 +112,7 @@ protected Collection<IBoxProvider> defaultProviders() {
 		List<IBoxProvider> result = new ArrayList<IBoxProvider>();
 		// order important (see BoxProviderImpl.supports())
 		// refactored to use this more generic method
-		result.add(createProviderForNameAndExtentions("c++",	Arrays.asList("*.c", "*.cpp", "*.h", "*.hpp") ) ); 
+		result.add(createProviderForNameAndExtentions("c++",	Arrays.asList("*.c", "*.cpp", "*.h", "*.hpp", "*.go") ) ); 
 		result.add(createProviderForNameAndExtentions("java",	Arrays.asList("*.java", "*.class", "*.gradle", "*.groovy", "*.scala") ) );
 		result.add(createProviderForNameAndExtentions("js",		Arrays.asList("*.js", "*.jjs", "*.jshintrc", "*.mjs", "*.njs", "*.pjs", "*.vjs", "*.ts", "*.coffee", "*.dart") ) );
 		result.add(createProviderForNameAndExtentions("lua",	Arrays.asList("*.lua") ) );
@@ -215,4 +228,5 @@ public void removePartListener(IPartService partService) {
 		if (oldListener != null)
 			partService.removePartListener(oldListener);
 	}
+
 }

pm.eclipse.editbox/src/pm/eclipse/editbox/pref/BoxSettingsTab.java

@@ -150,10 +150,9 @@ protected Control createControls(Composite parent) {
 		enabled = new Button(c, SWT.CHECK);
 		GridData gd = new GridData();
 		enabled.setLayoutData(gd);
-		enabled.setText("Enabled");
+		enabled.setText("Provider enabled");
 		enabled.setAlignment(SWT.RIGHT);
 		enabled.addSelectionListener(new SelectionAdapter() {
-
 			public void widgetSelected(SelectionEvent e) {
 				settings.setEnabled(enabled.getSelection());
 			}

pm.eclipse.editbox/src/pm/eclipse/editbox/pref/EditboxPreferenceInitializer.java

@@ -0,0 +1,18 @@
+package pm.eclipse.editbox.pref;
+
+import org.eclipse.core.runtime.preferences.AbstractPreferenceInitializer;
+import org.eclipse.jface.preference.IPreferenceStore;
+
+import pm.eclipse.editbox.EditBox;
+import pm.eclipse.editbox.impl.BoxProviderRegistry;
+
+public class EditboxPreferenceInitializer extends AbstractPreferenceInitializer {
+
+	@Override
+	public void initializeDefaultPreferences() {
+		IPreferenceStore store = EditBox.getDefault().getPreferenceStore();
+		store.setDefault(EditBox.PREF_ENABLED, true);
+		store.setDefault(EditBox.PREF_DEFAULT_THEME, BoxProviderRegistry.DEFAULT_THEME);
+		//TODO move defaults from BoxProviderRegistry into this EditboxPreferenceInitializer
+	}	
+}