Skip to content

Commit 20b377f

Browse files
committed
staged, not released
1 parent 0e1e39c commit 20b377f

File tree

2 files changed

+22
-15
lines changed

2 files changed

+22
-15
lines changed

org.nodeclipse.java.avatarjs/src/org/nodeclipse/java/avatarjs/launch/LaunchConfigurationDelegate.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* Launching `jjs` from Java 8.<br>
2929
* see LaunchConfigurationDelegate in .debug and .phantomjs module for comparison.
3030
*
31-
* @since 0.7
31+
* @since 0.15
3232
* @author Paul Verest
3333
*/
3434
public class LaunchConfigurationDelegate implements ILaunchConfigurationDelegate {
@@ -53,7 +53,7 @@ public void launch(ILaunchConfiguration configuration, String mode,
5353
// Dialogs.showPreferencesDialog("path to jjs util from Java 8 runtime is not correctly configured.\n\n"
5454
// + "Please goto Window -> Prefrences -> Nodeclipse and configure the correct location under 'JJS path:'");
5555
CommonDialogs.showPreferencesDialog(AvatarjsConstants.PREFERENCES_PAGE,
56-
"Java 8 Nashorn jjs location is not correctly configured.\n\n"
56+
"Java 8 location is not correctly configured.\n\n"
5757
+ "Please goto Window -> Preferences -> "+AvatarjsConstants.PREFERENCE_PAGE_NAME
5858
+" and configure the correct location");
5959
return;

org.nodeclipse.java.avatarjs/src/org/nodeclipse/java/avatarjs/preferences/AvatarjsPreferencePage.java

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,26 @@
33
import org.eclipse.jface.preference.BooleanFieldEditor;
44
import org.eclipse.jface.preference.FieldEditorPreferencePage;
55
import org.eclipse.jface.preference.FileFieldEditor;
6+
import org.eclipse.jface.preference.StringFieldEditor;
67
import org.eclipse.ui.IWorkbench;
78
import org.eclipse.ui.IWorkbenchPreferencePage;
8-
import org.nodeclipse.ui.Activator;
9-
import org.nodeclipse.ui.preferences.PreferenceConstants;
9+
import org.nodeclipse.java.avatarjs.Activator;
1010

1111
/**
1212
* @author Paul Verest
1313
* @since 0.11 moved from NodePreferencePage
1414
*/
1515
public class AvatarjsPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage {
1616

17-
private FileFieldEditor jjsPath;
18-
private BooleanFieldEditor jjsJustJJS;
17+
private FileFieldEditor javaPath;
18+
private BooleanFieldEditor javaJustJava;
19+
private StringFieldEditor javaOptions;
20+
private StringFieldEditor javaOptionsToRunWithAvatarjs;
1921

2022
public AvatarjsPreferencePage(){
2123
super(GRID);
22-
// ! uses .ui
2324
setPreferenceStore(Activator.getDefault().getPreferenceStore());
24-
setDescription("Java 8 Nashorn jjs settings");
25+
setDescription("Java 8 Avatar.js settings");
2526
}
2627

2728
@Override
@@ -30,13 +31,19 @@ public void init(IWorkbench workbench) {
3031

3132
@Override
3233
protected void createFieldEditors() {
33-
jjsPath = new FileFieldEditor(PreferenceConstants.JJS_PATH, "`jjs` path:", getFieldEditorParent());
34-
addField(jjsPath);
35-
36-
jjsJustJJS = new BooleanFieldEditor(PreferenceConstants.JJS_JUST_JJS,
37-
"just `jjs` (find `jjs` on PATH. Useful when there are 2 or more JDK 8 instances)", getFieldEditorParent());
38-
addField(jjsJustJJS);
39-
34+
javaPath = new FileFieldEditor(AvatarjsConstants.JAVA_PATH, "Java path:", getFieldEditorParent());
35+
addField(javaPath);
36+
37+
javaJustJava = new BooleanFieldEditor(AvatarjsConstants.JAVA_JUST_JAVA,
38+
"just `java` (find `java` on PATH. Useful when there are 2 or more JDK 8 instances)", getFieldEditorParent());
39+
addField(javaJustJava);
40+
41+
javaOptions = new StringFieldEditor(AvatarjsConstants.JAVA_OPTIONS, "`Java options:", getFieldEditorParent());
42+
addField(javaOptions);
43+
44+
javaOptionsToRunWithAvatarjs = new StringFieldEditor(AvatarjsConstants.JAVA_OPTIONS_TO_RUN_WITH_AVATARJS,
45+
"`Java options to run with Avatar.js:", getFieldEditorParent());
46+
addField(javaOptionsToRunWithAvatarjs);
4047
}
4148

4249
}

0 commit comments

Comments
 (0)