-
Notifications
You must be signed in to change notification settings - Fork 36
Open
Description
In #545 and #614 we ported the Hardhat stack trace generation logic, first verbatim, then with some changes to the memory management.
The code is still very hard to maintain due to:
- concurrent code paths for immutable and mutable access
- this should be avoidable as the stack trace is generated once and then never modified
- multiple layers of conversion, from
CallTraceArenatoNestedTracetoSolidityStackTrace- ideally we simplify this to a direct conversion from
CallTraceArenatoSolidityStackTrace
- ideally we simplify this to a direct conversion from
- the business logic operates by checking heuristics and returning if a match is found. This makes it very hard to create a high-level understanding of which heuristics are applied in which order and where to add new heuristics.
Definition of done
One or multiple design and implementation passes of refactors that address the above concerns
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Todo