Merge remote-tracking branch 'origin/v-next' into fs-traces

Author: galargh

.changeset/loud-buses-wave.md

@@ -0,0 +1,5 @@
+---
+"hardhat": patch
+---
+
+Allowed requesting help via the -h flag

.changeset/tiny-apes-tell.md

@@ -0,0 +1,5 @@
+---
+"hardhat": patch
+---
+
+Remove the `defaultNetwork` config option and introduce a network called `default` ([#6875](https://github.com/NomicFoundation/hardhat/issues/6875))

.changeset/twenty-lies-destroy.md

@@ -0,0 +1,5 @@
+---
+"hardhat": patch
+---
+
+Fix node crash when sending a tx with insufficient funds

.changeset/wild-boats-study.md

@@ -0,0 +1,7 @@
+---
+"@nomicfoundation/hardhat-errors": patch
+"@nomicfoundation/hardhat-verify": patch
+"hardhat": patch
+---
+
+Enable verification providers by default and throw if Etherscan apiKey is empty ([#6937](https://github.com/NomicFoundation/hardhat/pull/6937))

scripts/check-release.mjs

@@ -5,7 +5,7 @@ import { appendFile } from "node:fs/promises";
 import { readPackage, isPackageReleasedToNpm } from "./lib/packages.mjs";
 
 /**
- * The function checks whether the version of hardhat from its' package.json is available in the NPM registry
+ * The function checks whether the version of hardhat from its package.json is available in the NPM registry
  * It appends this information to the GITHUB_OUTPUT file (this is an env variable available in the GitHub Actions environment)
  */
 async function checkRelease() {

v-next/hardhat-errors/src/descriptors.ts

@@ -2620,6 +2620,17 @@ chainDescriptors: {
         websiteDescription: `The block explorer responded that the address does not contain a contract. This usually means the address is incorrect, the contract was not deployed on the selected network, or there is a temporary issue with the block explorer not updating its index.
 Please verify the address and network, and try again later if necessary.`,
       },
+      EXPLORER_API_KEY_EMPTY: {
+        number: 80030,
+        messageTemplate: `The {verificationProvider} API key is empty.`,
+        websiteTitle: "Block explorer API key is empty",
+        websiteDescription: `The provided API key for the block explorer is empty. This can happen in the following cases:
+- No "apiKey" field is configured in the hardhat config.
+- The "apiKey" is explicitly set to an empty string in the Hardhat config.
+- The "apiKey" is assigned to a config variable that resolves to an empty string at runtime.
+
+To resolve this, set a valid non-empty API key in your Hardhat config, then try again.`,
+      },
     },
     VALIDATION: {
       INVALID_ADDRESS: {

v-next/hardhat-ethers/test/gas-config.ts

@@ -10,7 +10,7 @@ import { before, describe, it } from "node:test";
 import { initializeTestEthers } from "./helpers/helpers.js";
 
 type GasLimitValue = "default" | "auto" | bigint;
-type ConnectedNetwork = "hardhat" | "localhost";
+type ConnectedNetwork = "default" | "localhost";
 
 interface Combination {
   hardhatGasLimit: GasLimitValue;
@@ -34,7 +34,7 @@ function generateCombinations(): Combination[] {
     1_000_000n,
   ];
 
-  // TODO: enable when V3 is ready: V3 node required - add hardhat network -> ["hardhat", "localhost"];
+  // TODO: enable when V3 is ready: V3 node required - add hardhat network -> ["default", "localhost"];
   const connectedNetworkValues: ConnectedNetwork[] = ["localhost"];
 
   for (const hardhatGasLimit of hardhatGasLimitValues) {
@@ -67,7 +67,7 @@ describe("gas config behavior", () => {
           { artifactName: "Example", fileName: "gas-config" },
         ]));
 
-        if (hardhatGasLimit !== "default" && connectedNetwork === "hardhat") {
+        if (hardhatGasLimit !== "default" && connectedNetwork === "default") {
           networkConfig.gas = hardhatGasLimit;
         }
 
@@ -85,12 +85,12 @@ describe("gas config behavior", () => {
       // the result of an estimateGas call should be used
       let defaultGasLimit: bigint | undefined;
       if (
-        (connectedNetwork === "hardhat" && hardhatGasLimit === 1_000_000n) ||
+        (connectedNetwork === "default" && hardhatGasLimit === 1_000_000n) ||
         (connectedNetwork === "localhost" && localhostGasLimit === 1_000_000n)
       ) {
         defaultGasLimit = 1_000_000n;
       } else if (
-        (connectedNetwork === "hardhat" && hardhatGasLimit === "default") ||
+        (connectedNetwork === "default" && hardhatGasLimit === "default") ||
         (connectedNetwork === "localhost" && localhostGasLimit === "default")
       ) {
         // expect the block gas limit to be used as the default gas limit

v-next/hardhat-ethers/test/hardhat-ethers-provider.ts

@@ -136,7 +136,7 @@ describe("hardhat ethers provider", () => {
   // it("should return the network", async ()=>{
   //   const network = await ethers.provider.getNetwork();
 
-  //   assert.equal(network.name, "hardhat");
+  //   assert.equal(network.name, "default");
   //   assert.equal(network.chainId, 31337n);
   // });
 

v-next/hardhat-ethers/test/hardhat-ethers-signer.ts

@@ -157,7 +157,7 @@ describe("hardhat ethers signer", () => {
         const { ethers: hhEthers, provider: hhProvider } =
           await initializeTestEthers([], {
             networks: {
-              hardhat: {
+              default: {
                 type: "edr",
                 accounts: [
                   { balance: "1000000000000000000", privateKey: TEST_P_KEY_1 },
@@ -174,7 +174,7 @@ describe("hardhat ethers signer", () => {
         const { ethers: hhEthers, provider: hhProvider } =
           await initializeTestEthers([], {
             networks: {
-              hardhat: {
+              default: {
                 type: "edr",
                 accounts: HD_ACCOUNTS,
               },

v-next/hardhat-ethers/test/helpers/helpers.ts

@@ -25,7 +25,7 @@ export async function initializeTestEthers(
   const hre = await createHardhatRuntimeEnvironment(config);
 
   const network =
-    config.networks?.localhost !== undefined ? "localhost" : "hardhat";
+    config.networks?.localhost !== undefined ? "localhost" : "default";
 
   const connection = await hre.network.connect(network);