Merge pull request #7022 from NomicFoundation/fix/update-ignition-network-connection

Fix to update ignition network connection

Author: kanej

.changeset/large-suns-shout.md

@@ -0,0 +1,5 @@
+---
+"hardhat": patch
+---
+
+Fix `--network` passing as a command line option ([#7022](https://github.com/NomicFoundation/hardhat/pull/7022))

pnpm-lock.yaml

@@ -85,7 +85,7 @@
     "typescript": "~5.8.0"
   },
   "dependencies": {
-    "@ignored/edr-optimism": "0.13.0-alpha.7",
+    "@ignored/edr-optimism": "0.13.0-alpha.6",
     "@nomicfoundation/hardhat-errors": "workspace:^3.0.0-next.22",
     "@nomicfoundation/hardhat-utils": "workspace:^3.0.0-next.22",
     "@nomicfoundation/hardhat-zod-utils": "workspace:^3.0.0-next.22",

v-next/hardhat/package.json

@@ -1,6 +1,8 @@
 import type { HardhatRuntimeEnvironmentHooks } from "../../../../types/hooks.js";
 import type { NetworkManager } from "../../../../types/network.js";
 
+import { DEFAULT_NETWORK_NAME } from "../../../constants.js";
+
 export default async (): Promise<Partial<HardhatRuntimeEnvironmentHooks>> => ({
   created: async (context, hre) => {
     let networkManager: NetworkManager | undefined;
@@ -15,6 +17,9 @@ export default async (): Promise<Partial<HardhatRuntimeEnvironmentHooks>> => ({
 
         if (networkManager === undefined) {
           networkManager = new NetworkManagerImplementation(
+            hre.globalOptions.network !== undefined
+              ? hre.globalOptions.network
+              : DEFAULT_NETWORK_NAME,
             hre.config.defaultChainType,
             hre.config.networks,
             context.hooks,

v-next/hardhat/src/internal/builtin-plugins/network-manager/hook-handlers/hre.ts

@@ -24,7 +24,6 @@ import { HardhatError } from "@nomicfoundation/hardhat-errors";
 import { readBinaryFile } from "@nomicfoundation/hardhat-utils/fs";
 import { deepMerge } from "@nomicfoundation/hardhat-utils/lang";
 
-import { DEFAULT_NETWORK_NAME } from "../../constants.js";
 import { resolveConfigurationVariable } from "../../core/configuration-variables.js";
 import { isSupportedChainType } from "../../edr/chain-type.js";
 
@@ -40,6 +39,7 @@ export type JsonRpcRequestWrapperFunction = (
 ) => Promise<JsonRpcResponse>;
 
 export class NetworkManagerImplementation implements NetworkManager {
+  readonly #defaultNetwork: string;
   readonly #defaultChainType: DefaultChainType;
   readonly #networkConfigs: Readonly<Record<string, Readonly<NetworkConfig>>>;
   readonly #hookManager: Readonly<HookManager>;
@@ -50,13 +50,15 @@ export class NetworkManagerImplementation implements NetworkManager {
   #nextConnectionId = 0;
 
   constructor(
+    defaultNetwork: string,
     defaultChainType: DefaultChainType,
     networkConfigs: Record<string, NetworkConfig>,
     hookManager: HookManager,
     artifactsManager: ArtifactManager,
     userConfigNetworks: Record<string, NetworkUserConfig> | undefined,
     chainDescriptors: ChainDescriptorsConfig,
   ) {
+    this.#defaultNetwork = defaultNetwork;
     this.#defaultChainType = defaultChainType;
     this.#networkConfigs = networkConfigs;
     this.#hookManager = hookManager;
@@ -100,7 +102,7 @@ export class NetworkManagerImplementation implements NetworkManager {
     chainType?: ChainTypeT,
     networkConfigOverride?: NetworkConfigOverride,
   ): Promise<NetworkConnection<ChainTypeT>> {
-    const resolvedNetworkName = networkName ?? DEFAULT_NETWORK_NAME;
+    const resolvedNetworkName = networkName ?? this.#defaultNetwork;
 
     if (this.#networkConfigs[resolvedNetworkName] === undefined) {
       throw new HardhatError(

v-next/hardhat/src/internal/builtin-plugins/network-manager/network-manager.ts

@@ -126,25 +126,12 @@ describe("NetworkManagerImplementation", () => {
         "",
         (varOrStr) => resolveConfigurationVariable(hre.hooks, varOrStr),
       ),
-      default: resolveEdrNetwork(
-        {
-          type: "edr",
-          initialDate,
-          mining: {
-            auto: true,
-            mempool: {
-              order: "priority",
-            },
-          },
-        },
-        "",
-        (varOrStr) => resolveConfigurationVariable(hre.hooks, varOrStr),
-      ),
     };
 
     chainDescriptors = await resolveChainDescriptors(undefined);
 
     networkManager = new NetworkManagerImplementation(
+      "localhost",
       GENERIC_CHAIN_TYPE,
       networks,
       hre.hooks,
@@ -157,9 +144,9 @@ describe("NetworkManagerImplementation", () => {
   describe("connect", () => {
     it("should connect to the default network and chain type if none are provided", async () => {
       const networkConnection = await networkManager.connect();
-      assert.equal(networkConnection.networkName, "default");
+      assert.equal(networkConnection.networkName, "localhost");
       assert.equal(networkConnection.chainType, GENERIC_CHAIN_TYPE);
-      assert.deepEqual(networkConnection.networkConfig, networks.default);
+      assert.deepEqual(networkConnection.networkConfig, networks.localhost);
     });
 
     it("should connect to the specified network and default chain type if none are provided and the network doesn't have a chain type", async () => {