Fix tests

Author: antico5

.changeset/unlucky-monkeys-speak.md

@@ -0,0 +1,6 @@
+---
+"@nomicfoundation/hardhat-verify": patch
+"hardhat": patch
+---
+
+Minimize compilation jobs based on changes in files and config across runs

v-next/hardhat-verify/src/internal/artifacts.ts

@@ -76,14 +76,22 @@ export async function getCompilerInput(
   sourceName: string,
   buildProfileName: string,
 ): Promise<CompilerInput> {
-  const compilationJob = await solidity.getCompilationJobs(
+  const getCompilationJobsResult = await solidity.getCompilationJobs(
     [path.join(rootFilePath, sourceName)],
     {
       buildProfile: buildProfileName,
       quiet: true,
+      force: true,
     },
   );
 
+  assertHardhatInvariant(
+    !("reason" in getCompilationJobsResult),
+    "getCompilationJobs should not error",
+  );
+
+  const compilationJob = getCompilationJobsResult.compilationJobsPerFile;
+
   // TODO: should this be an error instead?
   assertHardhatInvariant(
     compilationJob instanceof Map && compilationJob.size === 1,

v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/build-system.ts

@@ -27,10 +27,20 @@ import { HookManagerImplementation } from "../../../../../src/internal/core/hook
 
 async function emitArtifacts(solidity: SolidityBuildSystem): Promise<void> {
   const rootFilePaths = await solidity.getRootFilePaths();
-  const compilationJobs = await solidity.getCompilationJobs(rootFilePaths, {
-    isolated: false,
-    quiet: true,
-  });
+  const compilationJobsResult = await solidity.getCompilationJobs(
+    rootFilePaths,
+    {
+      isolated: false,
+      quiet: true,
+    },
+  );
+
+  assert.ok(
+    !("reason" in compilationJobsResult),
+    "getCompilationJobs should not error",
+  );
+
+  const compilationJobs = compilationJobsResult.compilationJobsPerFile;
 
   assert.ok(compilationJobs instanceof Map, "compilationJobs should be a Map");
 
@@ -264,25 +274,6 @@ describe(
         );
       });
 
-      it("should not recompile the project when given the same input as in the previous call", async () => {
-        const rootFilePaths = await solidity.getRootFilePaths();
-        await solidity.build(rootFilePaths, {
-          force: true,
-          isolated: false,
-          quiet: true,
-        });
-
-        const runCompilationJobSpy = mock.method(solidity, "runCompilationJob");
-
-        await solidity.build(rootFilePaths, {
-          force: false,
-          isolated: false,
-          quiet: true,
-        });
-
-        assert.equal(runCompilationJobSpy.mock.callCount(), 0);
-      });
-
       it("should recompile the project when given the same input as in the previous call but the force flag is set", async () => {
         const rootFilePaths = await solidity.getRootFilePaths();
         await solidity.build(rootFilePaths, {
@@ -302,81 +293,6 @@ describe(
         assert.equal(runCompilationJobSpy.mock.callCount(), 2);
       });
 
-      it("should not recompile the project when the input changed but the generated compilation jobs are the subset of the previous ones", async () => {
-        const rootFilePaths = await solidity.getRootFilePaths();
-        await solidity.build(rootFilePaths, {
-          force: true,
-          isolated: false,
-          quiet: true,
-        });
-
-        const runCompilationJobSpy = mock.method(solidity, "runCompilationJob");
-
-        await solidity.build(
-          rootFilePaths.filter((f) => path.basename(f) !== "NoImports.sol"),
-          {
-            force: false,
-            isolated: false,
-            quiet: true,
-          },
-        );
-
-        assert.equal(runCompilationJobSpy.mock.callCount(), 0);
-      });
-
-      it("should recompile the project when the input changed and the generated compilation jobs changed", async () => {
-        const rootFilePaths = await solidity.getRootFilePaths();
-        await solidity.build(rootFilePaths, {
-          force: true,
-          isolated: false,
-          quiet: true,
-        });
-
-        const runCompilationJobSpy = mock.method(solidity, "runCompilationJob");
-
-        await solidity.build(
-          rootFilePaths.filter((f) => path.basename(f) !== "A.sol"),
-          {
-            force: false,
-            isolated: false,
-            quiet: true,
-          },
-        );
-
-        assert.equal(runCompilationJobSpy.mock.callCount(), 1);
-      });
-
-      it("should not recompile the project when the input is the same as in one of the previous calls", async () => {
-        const rootFilePaths = await solidity.getRootFilePaths();
-        await solidity.build(rootFilePaths, {
-          force: true,
-          isolated: false,
-          quiet: true,
-        });
-
-        await solidity.build(
-          rootFilePaths.filter((f) => path.basename(f) !== "A.sol"),
-          {
-            force: false,
-            isolated: false,
-            quiet: true,
-          },
-        );
-
-        const runCompilationJobSpy = mock.method(solidity, "runCompilationJob");
-
-        await solidity.build(
-          rootFilePaths.filter((f) => path.basename(f) !== "A.sol"),
-          {
-            force: false,
-            isolated: false,
-            quiet: true,
-          },
-        );
-
-        assert.equal(runCompilationJobSpy.mock.callCount(), 0);
-      });
-
       it("should throw when given a build profile that is not defined", async () => {
         const rootFilePaths = await solidity.getRootFilePaths();